Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30771

Students unable to view rubric definition prior to submission

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      1. As a teacher create a rubric-graded assignment and define a rubric (see MDLQA-1185 for reference)
      2. Make sure the option "Allow users to preview rubric" is checked
      3. Login as a student and make sure you can preview the rubric (in navigation menu, under module name)
      4. Login as a teacher and uncheck the option
      5. Login as a student and make sure you don't see the rubric

      Show
      1. As a teacher create a rubric-graded assignment and define a rubric (see MDLQA-1185 for reference) 2. Make sure the option "Allow users to preview rubric" is checked 3. Login as a student and make sure you can preview the rubric (in navigation menu, under module name) 4. Login as a teacher and uncheck the option 5. Login as a student and make sure you don't see the rubric
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
      git@github.com:marinaglancy/moodle.git
    • Pull Master Branch:
      wip-MDL-30771-master

      Description

      When using advanced grading (rubrics), I would argue that the student should be able to see the definition of the rubric prior to submitting their work. After all, isn't this the main point of rubric assessment? That students are fully informed of the 'rules' of assessment? I think there's only limited benefit to the student in showing the rubric after grading has occurred.

      See this forum for the original discussion --> http://moodle.org/mod/forum/discuss.php?d=191741

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            I agree with this. It should be optional, but it should definitely be possible.

            Show
            salvetore Michael de Raadt added a comment - I agree with this. It should be optional, but it should definitely be possible.
            Hide
            monkrob Rob Monk added a comment -

            Agreed. There is little point having a rubric that you hide from the kiddies. Bit like saying go and play the game and I'll explain the rules and scoring system afterwards. It will be a pretty messy game.

            Show
            monkrob Rob Monk added a comment - Agreed. There is little point having a rubric that you hide from the kiddies. Bit like saying go and play the game and I'll explain the rules and scoring system afterwards. It will be a pretty messy game.
            Hide
            ray Ray Lawrence added a comment -

            +1

            Show
            ray Ray Lawrence added a comment - +1
            Hide
            alrachels AL Rachels added a comment -

            +1

            Show
            alrachels AL Rachels added a comment - +1
            Hide
            mudrd8mz David Mudrak added a comment -

            Thanks for working on this Marina. I did not test the patch but I went through it to understand the overall logic. I believe I mentioned it already in our private chat the other day: the thing I would generally do in another way is that you seem to prefer per-rubric options while I would use capabilities. Especially for this (form preview) sort of things. Both approaches have their cons and pros. In the future, when there is an eventual demand, we can try and re-think these thing and maybe to combine both per-rubric options and capabilities. For now, I say runway free +1

            Show
            mudrd8mz David Mudrak added a comment - Thanks for working on this Marina. I did not test the patch but I went through it to understand the overall logic. I believe I mentioned it already in our private chat the other day: the thing I would generally do in another way is that you seem to prefer per-rubric options while I would use capabilities. Especially for this (form preview) sort of things. Both approaches have their cons and pros. In the future, when there is an eventual demand, we can try and re-think these thing and maybe to combine both per-rubric options and capabilities. For now, I say runway free +1
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Marina,

            I've just been looking at this now, I'm sending it back this week so that the following notes can be considered/addressed.

            1. There are a couple of things about the navigation changes that concern me:
              1. Within navigationlib advanced grading navigation is not loaded if the activity module extends the navigation itself. I feel if we are going to automatically extend the navigation then we should do so consistently.
              2. What are the performance implications of this change? How many additional files and database calls does this change cause? (looks like this only occurs when the user causes the navigation to load an activity either by viewing the activity or by expanding it with AJAX)
            2. I personally think that this should only be applied to master and not backported. As a rule we don't backport any improvements or new features unless there is a very good reason to do so.
              If there are no objects then this will be master only, however please if there is a good reason to backport raise it and we can discuss it.

            I think from the above points really only 1.1 requires code changes. 1.2 I'm just looking for clarification on performance, and 2 is up to you

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Marina, I've just been looking at this now, I'm sending it back this week so that the following notes can be considered/addressed. There are a couple of things about the navigation changes that concern me: Within navigationlib advanced grading navigation is not loaded if the activity module extends the navigation itself. I feel if we are going to automatically extend the navigation then we should do so consistently. What are the performance implications of this change? How many additional files and database calls does this change cause? (looks like this only occurs when the user causes the navigation to load an activity either by viewing the activity or by expanding it with AJAX) I personally think that this should only be applied to master and not backported. As a rule we don't backport any improvements or new features unless there is a very good reason to do so. If there are no objects then this will be master only, however please if there is a good reason to backport raise it and we can discuss it. I think from the above points really only 1.1 requires code changes. 1.2 I'm just looking for clarification on performance, and 2 is up to you Cheers Sam
            Hide
            marina Marina Glancy added a comment -

            Sam, thanks for your comment
            1.1 I fixed the lib/navigationlib.php and re-committed
            1.2 no performance implications if module is not supporting advanced grading.
            For assignments that support advanced grading but do not use it there is one extra DB query (in grading_manager::load).
            If this is an assignment with active advanced grading we will also retrieve form definition to check that option to show it to students is enabled. But for the purpose of building navigation there are 2-3 indexed DB queries.

            2. Martin wanted it to be in 2.2 as well

            Show
            marina Marina Glancy added a comment - Sam, thanks for your comment 1.1 I fixed the lib/navigationlib.php and re-committed 1.2 no performance implications if module is not supporting advanced grading. For assignments that support advanced grading but do not use it there is one extra DB query (in grading_manager::load). If this is an assignment with active advanced grading we will also retrieve form definition to check that option to show it to students is enabled. But for the purpose of building navigation there are 2-3 indexed DB queries. 2. Martin wanted it to be in 2.2 as well
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Cool thanks for the reply and changes Marina, looking at this again now

            Show
            samhemelryk Sam Hemelryk added a comment - Cool thanks for the reply and changes Marina, looking at this again now
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Marina - has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Marina - has been integrated now
            Hide
            andyjdavis Andrew Davis added a comment -

            Works as described. Passing.

            Show
            andyjdavis Andrew Davis added a comment - Works as described. Passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

            Closing as fixed, heading to zzzZZZzzz, niao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao
            Hide
            ktondryk Kim Tondryk added a comment -

            I was excited to see that this was fixed. We upgraded to Moodle 2.2 last week but the feature does not seem to work?! I can see the new checkbox when I create a new rubric, "Allow users to preview rubric used in the module (otherwise rubric will only become visible after grading)," but even though it is checked students are still not able to see the rubric when they click on the assignment activity. I've tried creating several different types of assignements with the rubric - single file upload, advanced uploading, online text - but none of them allow the student to view the rubric.

            I have chosen to use a rubric in the Assignments settings, Grading Method field. I have clicked the Save Rubric and Make it Ready button after creating the rubric, and also made sure the "Allow users to preview rubric..." checkbox was checked. I have logged in with a test student account but could not see the rubric no matter which assignment type I tried.

            Show
            ktondryk Kim Tondryk added a comment - I was excited to see that this was fixed. We upgraded to Moodle 2.2 last week but the feature does not seem to work?! I can see the new checkbox when I create a new rubric, "Allow users to preview rubric used in the module (otherwise rubric will only become visible after grading)," but even though it is checked students are still not able to see the rubric when they click on the assignment activity. I've tried creating several different types of assignements with the rubric - single file upload, advanced uploading, online text - but none of them allow the student to view the rubric. I have chosen to use a rubric in the Assignments settings, Grading Method field. I have clicked the Save Rubric and Make it Ready button after creating the rubric, and also made sure the "Allow users to preview rubric..." checkbox was checked. I have logged in with a test student account but could not see the rubric no matter which assignment type I tried.
            Hide
            ktondryk Kim Tondryk added a comment -

            Well, I am a little embarrassed. I figured it out! Please ignore my comment above! And thank you!

            Show
            ktondryk Kim Tondryk added a comment - Well, I am a little embarrassed. I figured it out! Please ignore my comment above! And thank you!
            Hide
            marycooch Mary Cooch added a comment -

            As students can now see the rubric and this has been documented http://docs.moodle.org/22/en/Rubrics I am removing the docs_required label

            Show
            marycooch Mary Cooch added a comment - As students can now see the rubric and this has been documented http://docs.moodle.org/22/en/Rubrics I am removing the docs_required label

              People

              • Votes:
                12 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12