Moodle
  1. Moodle
  2. MDL-30778

intendedEndUserRole metadata not supported by cc import

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.3
    • Fix Version/s: 2.2.2
    • Component/s: Backup: IMS-CC
    • Labels:
    • Testing Instructions:
      Hide

      Import ccvtd0011v1p08.zip package (this is a part of CC 1.0 Valid data set that can be obtained from IMS)

      This package contains three weblinks marked as intentded only for instructors. After import these three links should be marked as hidden.

      Show
      Import ccvtd0011v1p08.zip package (this is a part of CC 1.0 Valid data set that can be obtained from IMS) This package contains three weblinks marked as intentded only for instructors. After import these three links should be marked as hidden.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      33712

      Description

      Common Cartridge standard supports resource metadata that can specify which users can or can not access that particular resource. Right now this is ignored during import.

        Activity

        Hide
        Darko Miletic added a comment -

        intendedEndUserRole meta-data element can be applied as a part of metadata for the cartridge resources within the manifest. It is added to the standard as a way of distinguishing whether a particular resource can be viewed by all users or only by some. When present intendedEndUserRole can have values of Learner and Instructor for CC 1.0 and values of Learner, Instructor and Mentor for CC 1.1. Since Moodle does not really have content restriction made on such a fine level we can implement this as follows:
        1. If intendedEndUserRole is not present - content can be viewed by all - nothing to do
        2. If intendedEndUserRole is present and it points to Instructor or Mentor - it means it should not be seen by the Learner - student and therefore it should be marked hidden
        3. If intendedEndUserRole is present and it points to Learner - it means it should only be seen by the Learner - student, but Moodle does not support this so we will have to ignore this case

        All off this applies if the resource is part of the organization structure - ie has an item that points to it. If intendedEndUserRole metadata is linked to a supporting resource (an image that gets loaded within an html page) there is nothing we can really do since, again, Moodle does not support this kind of restriction.

        Show
        Darko Miletic added a comment - intendedEndUserRole meta-data element can be applied as a part of metadata for the cartridge resources within the manifest. It is added to the standard as a way of distinguishing whether a particular resource can be viewed by all users or only by some. When present intendedEndUserRole can have values of Learner and Instructor for CC 1.0 and values of Learner, Instructor and Mentor for CC 1.1. Since Moodle does not really have content restriction made on such a fine level we can implement this as follows: 1. If intendedEndUserRole is not present - content can be viewed by all - nothing to do 2. If intendedEndUserRole is present and it points to Instructor or Mentor - it means it should not be seen by the Learner - student and therefore it should be marked hidden 3. If intendedEndUserRole is present and it points to Learner - it means it should only be seen by the Learner - student, but Moodle does not support this so we will have to ignore this case All off this applies if the resource is part of the organization structure - ie has an item that points to it. If intendedEndUserRole metadata is linked to a supporting resource (an image that gets loaded within an html page) there is nothing we can really do since, again, Moodle does not support this kind of restriction.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        I'm marking this as "integration_held" it simply means that this week we are still applying exclusively for patches 100% equivalent both on 22_STABLE and master.

        Next week that "on-sync" constraint will be over so this will be normally integrated.

        In the mean time, 2 comments / questions:

        1) This is really going only to (future) 2.3, aka master, or do we want it also for current 2.2 (22_STABLE)
        2) Providing one simple package and testing instructions would be really great. We should not integrate anything missing testing instructions.

        Show
        Eloy Lafuente (stronk7) added a comment - I'm marking this as "integration_held" it simply means that this week we are still applying exclusively for patches 100% equivalent both on 22_STABLE and master. Next week that "on-sync" constraint will be over so this will be normally integrated. In the mean time, 2 comments / questions: 1) This is really going only to (future) 2.3, aka master, or do we want it also for current 2.2 (22_STABLE) 2) Providing one simple package and testing instructions would be really great. We should not integrate anything missing testing instructions.
        Hide
        Darko Miletic added a comment -

        The 2.2 stable also contains cc import and hence since this improves cc import no reason not to push it into 2.2.

        Show
        Darko Miletic added a comment - The 2.2 stable also contains cc import and hence since this improves cc import no reason not to push it into 2.2.
        Hide
        Darko Miletic added a comment -

        Common Cartridge for testing this issue

        Show
        Darko Miletic added a comment - Common Cartridge for testing this issue
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Darko Miletic added a comment -

        OK, I will try doing that and if it fails I'll make new branches and update the issue.

        Show
        Darko Miletic added a comment - OK, I will try doing that and if it fails I'll make new branches and update the issue.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Thanks Darko!

        (note the rebase message above is an pseudo-automated one, so if your changes are in one area where nobody else applies fixes, surely you may ignore it - unless it conflicts with other issues already integrated, and rebase will "discover" that for sure).

        Ciao

        PS: Happy NY!

        Show
        Eloy Lafuente (stronk7) added a comment - Thanks Darko! (note the rebase message above is an pseudo-automated one, so if your changes are in one area where nobody else applies fixes, surely you may ignore it - unless it conflicts with other issues already integrated, and rebase will "discover" that for sure). Ciao PS: Happy NY!
        Hide
        Darko Miletic added a comment -

        Unable to rebase the existing branch so I created a new one.

        Show
        Darko Miletic added a comment - Unable to rebase the existing branch so I created a new one.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

        This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

        This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

        Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (22 and master). Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (22 and master). Thanks!
        Hide
        Gerard Caulfield added a comment -

        The "Content Updates", "Instructor's Manual" and "PowerPoint Presentations" links were all hidden in both master and 22.

        That import sure does take a very long time!

        Test passed

        Show
        Gerard Caulfield added a comment - The "Content Updates", "Instructor's Manual" and "PowerPoint Presentations" links were all hidden in both master and 22. That import sure does take a very long time! Test passed
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This virus has been spread upstream, everybody will be infected soon. Congrats, you did it!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This virus has been spread upstream, everybody will be infected soon. Congrats, you did it! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: