Moodle
  1. Moodle
  2. MDL-30786

show "to be deleted" instead of "missing" for some standard blocks and filters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.2.1
    • Component/s: Administration
    • Labels:
    • Rank:
      33723

      Description

      The problems is that we uninstall some standard plugins during upgrade, but the upgrade overview shows these plugins as missing which is confusing for admins, see http://moodle.org/mod/forum/discuss.php?d=192419

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          please note the master branch includes extra commit that removes the deleted plugins from 1.9-2.2 because 2.3 will support upgrade from 2.2 only.

          Show
          Petr Škoda added a comment - please note the master branch includes extra commit that removes the deleted plugins from 1.9-2.2 because 2.3 will support upgrade from 2.2 only.
          Hide
          Petr Škoda added a comment -

          one more thing - the legacy text filter handling is a bit borked, that is why it shows as "extension" for deleted standard filters - I tried to fix that but than decided it was not worth it, sorry

          Show
          Petr Škoda added a comment - one more thing - the legacy text filter handling is a bit borked, that is why it shows as "extension" for deleted standard filters - I tried to fix that but than decided it was not worth it, sorry
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          Petr I've looked this over everything is spot on. I've tested it and everything passed.
          The only thing I'm not 100% sure about is that master and MOODLE_22_STABLE differ ever so slightly after this change and Eloy told me that we need to keep things 100% in sync.
          So I've added Eloy to this issue

          Eloy the changes are 100% safe and no chance of conflicts in the next weeks, is it OK to put this in.
          If so it has been review + tested and I'm happy with it so feel free to put it in yourself or I will when I come online tomorrow.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, Petr I've looked this over everything is spot on. I've tested it and everything passed. The only thing I'm not 100% sure about is that master and MOODLE_22_STABLE differ ever so slightly after this change and Eloy told me that we need to keep things 100% in sync. So I've added Eloy to this issue Eloy the changes are 100% safe and no chance of conflicts in the next weeks, is it OK to put this in. If so it has been review + tested and I'm happy with it so feel free to put it in yourself or I will when I come online tomorrow. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          I've just talked to Eloy, we've already held off on other issues with similar scenarios until we are out of the on-sync period (1-week).
          Stopping the review and removing from integration.

          Show
          Sam Hemelryk added a comment - I've just talked to Eloy, we've already held off on other issues with similar scenarios until we are out of the on-sync period (1-week). Stopping the review and removing from integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Petr Škoda added a comment -

          rebased, thanks

          Show
          Petr Škoda added a comment - rebased, thanks
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now
          Hide
          Michael de Raadt added a comment -

          I tested this for 1.9->2.2, 2.0->2.2 and 2.1->2.2. With the 1.9->2.2 I still encounted "Missing from disk!" errors for exercise, hotpot, journal and lams while "To be deleted" was shown for admin, admin_tree, loancalc and search.

          Show
          Michael de Raadt added a comment - I tested this for 1.9->2.2, 2.0->2.2 and 2.1->2.2. With the 1.9->2.2 I still encounted "Missing from disk!" errors for exercise, hotpot, journal and lams while "To be deleted" was shown for admin, admin_tree, loancalc and search.
          Hide
          Petr Škoda added a comment - - edited

          Michael - of course, we do not delete the hotpot, journal, exercise and lams because it was just moved to contrib - this patch "to be deletes" only plugins that are deleted unconditionally and there is no way they could be reintroduced back as contrib.

          Show
          Petr Škoda added a comment - - edited Michael - of course, we do not delete the hotpot, journal, exercise and lams because it was just moved to contrib - this patch "to be deletes" only plugins that are deleted unconditionally and there is no way they could be reintroduced back as contrib.
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Hi,

          I'm going to consider this passed as far as, certainly, this is aimed to show the "to be deleted" message to well known core plugins that have been deleted on purpose (taking rid of them completely by dev decision, like loancalc), or moved to another plugintype/location forever (like the mod/xxx legacy filters). And not for "moved to contrib" ones. They continue being usable from there and the "missing from disk" message is ok for them. Surely the key point is that only "disappeared forever" standard plugins are suitable to show the new message, and everything else should continue showing "missing from disk" one.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Hi, I'm going to consider this passed as far as, certainly, this is aimed to show the "to be deleted" message to well known core plugins that have been deleted on purpose (taking rid of them completely by dev decision, like loancalc), or moved to another plugintype/location forever (like the mod/xxx legacy filters). And not for "moved to contrib" ones. They continue being usable from there and the "missing from disk" message is ok for them. Surely the key point is that only "disappeared forever" standard plugins are suitable to show the new message, and everything else should continue showing "missing from disk" one. Ciao
          Hide
          Michael de Raadt added a comment -

          This is still going to cause the confusion that this issue set out to resolve. The message "Missing from disk!" needs to be something else so that this makes sense.

          Show
          Michael de Raadt added a comment - This is still going to cause the confusion that this issue set out to resolve. The message "Missing from disk!" needs to be something else so that this makes sense.
          Hide
          Petr Škoda added a comment -

          It is missing from disk - which means "it was installed before, but PHP files are not there any more". Or do you mean something like "missing files because it was moved to contrib and if you need it do something with it yourself"?

          Show
          Petr Škoda added a comment - It is missing from disk - which means "it was installed before, but PHP files are not there any more". Or do you mean something like "missing files because it was moved to contrib and if you need it do something with it yourself"?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: