Moodle
  1. Moodle
  2. MDL-30791

Remove debugging notice from component_callback in 2.1 ONLY

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.1.3
        • Fix Version/s: 2.1.4
        • Component/s: Comments
        • Labels:
        • Testing Instructions:
          Hide
          1. Log in as admin.
          2. Turn debugging on if you havn't already.
          3. Add a comments block to the front page.
          4. Make sure you don't get any debugging notices.
          5. Make a couple of comments and verify things work.
          Show
          Log in as admin. Turn debugging on if you havn't already. Add a comments block to the front page. Make sure you don't get any debugging notices. Make a couple of comments and verify things work.
        • Affected Branches:
          MOODLE_21_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE
        • Pull from Repository:

          Description

          In 2.2 and greater this has been fixed already, however after recent changes in 2.1 this leads to lots of annoying debug notices.

            Gliffy Diagrams

              Issue Links

              has a non-specific relationship to

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29504 plugin_callback does not use frankenstyle function names

              • Critical - Crashes server, loss of data, severe memory leak
              • Closed

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30592 Quiz statistics report - images in the question text do not show up

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Linked a couple of relevant issues: MDL-29504 (2.2 > fix) and MDL-30592 where this issue was noticed

                Show
                Sam Hemelryk added a comment - Linked a couple of relevant issues: MDL-29504 (2.2 > fix) and MDL-30592 where this issue was noticed
                Hide
                Permalink
                Sam Hemelryk added a comment -

                This is MOODLE_21_STABLE only.

                Because we haven't released weeklies yet and there are relevant changes in integration I have based these changes upon the MOODLE_21_STABLE branch on the integration server.

                Cheers
                Sam

                Show
                Sam Hemelryk added a comment - This is MOODLE_21_STABLE only. Because we haven't released weeklies yet and there are relevant changes in integration I have based these changes upon the MOODLE_21_STABLE branch on the integration server. Cheers Sam
                Hide
                Permalink
                Tim Hunt added a comment -

                +1 from me.

                Show
                Tim Hunt added a comment - +1 from me.
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Thanks Tim - putting this up for integration now.

                Show
                Sam Hemelryk added a comment - Thanks Tim - putting this up for integration now.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Integrated, thanks!

                Show
                Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                And tested, site getting the debug (frontpage and course page) stopped getting it with the patch applied. Passing.

                Show
                Eloy Lafuente (stronk7) added a comment - And tested, site getting the debug (frontpage and course page) stopped getting it with the patch applied. Passing.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

                Now... disconnect, relax and enjoy the next days, yay!

                Closing...ciao

                Show
                Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: