Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30804

blocks/edit_form.php calls both fieldsets 'whereheader'

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2.1, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Blocks
    • Labels:
      None

      Description

      The block editing form names both fieldsets 'whereheader'
      The second field set should really have a different name

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dobedobedoh Andrew Nicols added a comment -

              I've renamed the second fieldset to match the label.

              This can be applied to:

              • master
              • MOODLE_22_STABLE
              • MOODLE_21_STABLE
              • MOODLE_20_STABLE
              Show
              dobedobedoh Andrew Nicols added a comment - I've renamed the second fieldset to match the label. This can be applied to: master MOODLE_22_STABLE MOODLE_21_STABLE MOODLE_20_STABLE
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Thanks Andrew for reporting and supplying patch to fix this issue.

              Patch looks good.

              Submitting for integration review.

              Show
              rwijaya Rossiani Wijaya added a comment - Thanks Andrew for reporting and supplying patch to fix this issue. Patch looks good. Submitting for integration review.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Andrew, good spotting changes look spot on. This will be integrated in the next integration cycle.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Andrew, good spotting changes look spot on. This will be integrated in the next integration cycle. Cheers Sam
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Andrew, this has been integrated now

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
              Hide
              skodak Petr Skoda added a comment -

              tested, thanks

              Show
              skodak Petr Skoda added a comment - tested, thanks
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jan/12