Moodle
  1. Moodle
  2. MDL-30804

blocks/edit_form.php calls both fieldsets 'whereheader'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2.1, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Blocks
    • Labels:
      None
    • Rank:
      33742

      Description

      The block editing form names both fieldsets 'whereheader'
      The second field set should really have a different name

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          I've renamed the second fieldset to match the label.

          This can be applied to:

          • master
          • MOODLE_22_STABLE
          • MOODLE_21_STABLE
          • MOODLE_20_STABLE
          Show
          Andrew Nicols added a comment - I've renamed the second fieldset to match the label. This can be applied to: master MOODLE_22_STABLE MOODLE_21_STABLE MOODLE_20_STABLE
          Hide
          Rossiani Wijaya added a comment -

          Thanks Andrew for reporting and supplying patch to fix this issue.

          Patch looks good.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Andrew for reporting and supplying patch to fix this issue. Patch looks good. Submitting for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, good spotting changes look spot on. This will be integrated in the next integration cycle.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Andrew, good spotting changes look spot on. This will be integrated in the next integration cycle. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
          Hide
          Petr Škoda added a comment -

          tested, thanks

          Show
          Petr Škoda added a comment - tested, thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: