Moodle
  1. Moodle
  2. MDL-30805

HTML Block should require the config_text field

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.0.7, 2.1.4, 2.2.1
        • Fix Version/s: 2.1.4, 2.2.1
        • Component/s: Blocks
        • Labels:
        • Testing Instructions:
          Hide

          Before

          • create a new HTML block
          • edit the block settings
          • save the form without filling in any content

          With Patch

          • create a new HTML block
          • edit the block settings
          • attempt to save the form without any content
          • ensure that the form is rejected without content
          • enter content
          • ensure that the form can now be submitted
          Show
          Before create a new HTML block edit the block settings save the form without filling in any content With Patch create a new HTML block edit the block settings attempt to save the form without any content ensure that the form is rejected without content enter content ensure that the form can now be submitted
        • Affected Branches:
          MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-30805-master-1
        • Pull Master Diff URL:
        • Rank:
          33743

          Description

          The HTML block defines a 'config_text' element to contain the HTML, but it isn't required.
          Given the nature of the block, it should ideally be a required field

            Issue Links

            will help resolve

            Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30806 Audit existing forms for inconsistent behaviour, missing required fields, field order

            • Minor - Minor loss of function where workaround is possible
            • Open

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Andrew Nicols added a comment -

              I've submitted this fix to require the HTML content on the HTML block.
              For the most part this isn't strictly required in Moodle, but would make sense in the context of the shortforms feature (MDL-30637)

              Show
              Andrew Nicols added a comment - I've submitted this fix to require the HTML content on the HTML block. For the most part this isn't strictly required in Moodle, but would make sense in the context of the shortforms feature ( MDL-30637 )
              Hide
              Permalink
              Rossiani Wijaya added a comment -

              Hi Andrew,

              Thank you for reporting and providing patch to fix this.

              The patch looks good.

              Submitting for integration review.

              Rosie

              Show
              Rossiani Wijaya added a comment - Hi Andrew, Thank you for reporting and providing patch to fix this. The patch looks good. Submitting for integration review. Rosie
              Hide
              Permalink
              Michael de Raadt added a comment -

              This should jump from the STABLE backlog to a fix version when it is integrated.

              Show
              Michael de Raadt added a comment - This should jump from the STABLE backlog to a fix version when it is integrated.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Changes look good thanks Andrew, this will be integrated in the next integration cycle (hopefully later today).

              Cheers
              Sam

              Show
              Sam Hemelryk added a comment - Changes look good thanks Andrew, this will be integrated in the next integration cycle (hopefully later today). Cheers Sam
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks Andrew, this has been integrated now

              Show
              Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
              Hide
              Permalink
              Petr Škoda added a comment -

              tested, thanks

              Show
              Petr Škoda added a comment - tested, thanks
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

              Closing, ciao

              Show
              Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: