Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30805

HTML Block should require the config_text field

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.7, 2.1.4, 2.2.1
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      Before

      • create a new HTML block
      • edit the block settings
      • save the form without filling in any content

      With Patch

      • create a new HTML block
      • edit the block settings
      • attempt to save the form without any content
      • ensure that the form is rejected without content
      • enter content
      • ensure that the form can now be submitted
      Show
      Before create a new HTML block edit the block settings save the form without filling in any content With Patch create a new HTML block edit the block settings attempt to save the form without any content ensure that the form is rejected without content enter content ensure that the form can now be submitted
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30805-master-1
    • Pull Master Diff URL:

      Description

      The HTML block defines a 'config_text' element to contain the HTML, but it isn't required.
      Given the nature of the block, it should ideally be a required field

        Attachments

          Issue Links

          will help resolve

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30806 Audit existing forms for inconsistent behaviour, missing required fields, field order

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Rossiani Wijaya Rossiani Wijaya
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Petr Skoda Petr Skoda
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/12