Moodle
  1. Moodle
  2. MDL-30809

Cannot prevent "guest access" enrolment method being added to new courses

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      1. Login as Admin and go to Site Administration > Plugins > Enrolments
      2. Click Guest Access and untick the "Add instance to new courses" box
      3. Click Manual enrolments and untick the "Add instance to new courses" box
      4. Go to Site Administration > Courses > Add/edit courses
      5. Add a new course
      6. Enter the new course and click Course Administration > Users > Enrolment methods
      7. Verify that neither "Guest access" nor "Manual enrolments" methods are listed.

      Show
      1. Login as Admin and go to Site Administration > Plugins > Enrolments 2. Click Guest Access and untick the "Add instance to new courses" box 3. Click Manual enrolments and untick the "Add instance to new courses" box 4. Go to Site Administration > Courses > Add/edit courses 5. Add a new course 6. Enter the new course and click Course Administration > Users > Enrolment methods 7. Verify that neither "Guest access" nor "Manual enrolments" methods are listed.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w52_MDL-30809_m23_guestinstance

      Description

      The site administration settings provide a setting for whether or not "Guest access" enrolment method is to be added to new courses by default. Unticking the box has no effect; the method is still added to new courses.

      The corresponding setting used for Manual enrolments works as expected.

      Steps to reproduce
      ==============
      1. Login as Admin and go to Site Administration > Plugins > Enrolments
      2. Click Guest Access and untick the "Add instance to new courses" box
      3. Click Manual enrolments and untick the "Add instance to new courses" box
      4. Go to Site Administration > Courses > Add/edit courses
      5. Add a new course
      6. Enter the new course and click Course Administration > Users > Enrolment methods

      Expected result
      ===========
      Neither "Guest access" nor "Manual enrolments" methods should be listed.

      Actual result
      =========
      "Guest access" method is listed, "Manual enrolments" method is not.

        Gliffy Diagrams

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this. I was able to reproduce the problem.

          I've put that on the backlog.

          In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. I was able to reproduce the problem. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.
          Hide
          Petr Skoda added a comment -

          Hello, I am confirming the issue, the "Add course form" should not include the guest section at all when the guest plugin is configured to not add guest instance by default. I am testing a patch right now, ciao.

          Show
          Petr Skoda added a comment - Hello, I am confirming the issue, the "Add course form" should not include the guest section at all when the guest plugin is configured to not add guest instance by default. I am testing a patch right now, ciao.
          Hide
          Petr Skoda added a comment -

          to integrators: please cherry pick to 2.1.x and 2.2.x, thanks.

          Show
          Petr Skoda added a comment - to integrators: please cherry pick to 2.1.x and 2.2.x, thanks.
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now
          Hide
          Ankit Agarwal added a comment -

          Hi,
          This is working great!
          Passing
          Thanks

          Show
          Ankit Agarwal added a comment - Hi, This is working great! Passing Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: