[MDL-30815] unlabelled form elements for choices - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
~~MDL-30815~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/MDL-30815-master
Difficulty:
Easy
Testing Instructions:
Hide

Login as Admin, goto a course and add a choice activity

view the activity and check the html source of the page.

Make sure you see the id as an attribute to the input field.

Make sure the for attribute of the label filed is same as the id attribute of input field

Example:-

<input id="choice_1" type="radio" name="answer" value="red" />

<label for="choice_1">Red</label>
Show
Login as Admin, goto a course and add a choice activity view the activity and check the html source of the page. Make sure you see the id as an attribute to the input field. Make sure the for attribute of the label filed is same as the id attribute of input field Example:- <input id="choice_1" type="radio" name="answer" value="red" /> <label for="choice_1">Red</label>

Each input element needs to be explicitly tied to a form label. The correct code looks like the following.

<input id="choice_1" type="radio" name="answer" value="red" />

<label for="choice_1">Red</label>

<input id="choice_2" type="radio" name="answer" value="blue" />

<label for="choice_2">Blue</label>

<input id="choice_3" type="radio" name="answer" value="green" />

<label for="choice_3">Green</label>

The key is to have each input element directly attached to a label through a common "id" and "for" attribute.

Participants:: Andrew Davis, Ankit Agarwal, Eloy Lafuente (stronk7), Greg Kraus, Jason Fowler, Michael de Raadt, Sam Hemelryk

Component watchers:: Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)