Details

    • Testing Instructions:
      Hide
      1. Log in as admin and set editing on
      2. Enable completion tracking (Settings -> Site administration -> Advanced features)
      3. Select a course and edit settings, enabling Completion tracking
      4. Add "upload a single file" activity with Completion tracking set to "Students can manually mark.."
      5. Add another "upload a single file" activity with Completion tracking set to "Show activity as completed when .." and check require view
      6. Go back to course and turn editing off
      7. Open firebug and inspect checkbox elements. Title and alt should be prefixed with name of the activity
        Title: {Name of the activity}; mark as complete.
        Alt: {Name of the activity}

        is not complete; select to mark as complete.

      Show
      Log in as admin and set editing on Enable completion tracking (Settings -> Site administration -> Advanced features) Select a course and edit settings, enabling Completion tracking Add "upload a single file" activity with Completion tracking set to "Students can manually mark.." Add another "upload a single file" activity with Completion tracking set to "Show activity as completed when .." and check require view Go back to course and turn editing off Open firebug and inspect checkbox elements. Title and alt should be prefixed with name of the activity Title: {Name of the activity}; mark as complete. Alt: {Name of the activity} is not complete; select to mark as complete.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      wip-mdl-30817
    • Rank:
      33758

      Description

      It can be difficult for screen reader users to associate the check mark with the corresponding resource or activity on the main course page. The alt text for the image should read something like "Mid-term homework not completed. Select to mark as complete." This way the screen reader user will know exactly which check mark goes with which item on the page.

        Issue Links

          Activity

          Hide
          Greg Kraus added a comment -

          This is the current code for the completion completion check mark

          <input type="image" title="Mark as not complete" alt="Completed; select to mark as not complete" src="https://moodle-access.delta.ncsu.edu/theme/image.php?theme=standard&image=i%2Fcompletion-manual-y&rev=172">

          It should be something more like this. (This assumes the completion check mark is for a resource entitled "Course Introduction"

          <input type="image" title="Course Introduction, mark as not complete" alt="Course Introduction completed; select to mark as not complete" src="https://moodle-access.delta.ncsu.edu/theme/image.php?theme=standard&image=i%2Fcompletion-manual-y&rev=172">

          Show
          Greg Kraus added a comment - This is the current code for the completion completion check mark <input type="image" title="Mark as not complete" alt="Completed; select to mark as not complete" src="https://moodle-access.delta.ncsu.edu/theme/image.php?theme=standard&image=i%2Fcompletion-manual-y&rev=172"> It should be something more like this. (This assumes the completion check mark is for a resource entitled "Course Introduction" <input type="image" title="Course Introduction, mark as not complete" alt="Course Introduction completed; select to mark as not complete" src="https://moodle-access.delta.ncsu.edu/theme/image.php?theme=standard&image=i%2Fcompletion-manual-y&rev=172">
          Hide
          Glenn Ansley added a comment - - edited

          This looks pretty clean to me. You may want to have someone else check behind me though. The only thing I would question are the lines like this one:

          $imgtitle = s($mod->name.get_string('completion-title-'.$completionicon, 'completion'));)

          I'm not sure whether the preferred syntax is concatenate the modulename with the get_string call or to pass it to the function as the 3rd parameter. I guess that depends on whether or not module names get translated.

          Show
          Glenn Ansley added a comment - - edited This looks pretty clean to me. You may want to have someone else check behind me though. The only thing I would question are the lines like this one: $imgtitle = s($mod->name.get_string('completion-title-'.$completionicon, 'completion'));) I'm not sure whether the preferred syntax is concatenate the modulename with the get_string call or to pass it to the function as the 3rd parameter. I guess that depends on whether or not module names get translated.
          Hide
          Rajesh Taneja added a comment -

          Thanks for the feedback Glenn,
          You are right, I should have used third parameter, rather then concatenation. Have updated the branches with proper params.
          It will be helpful, to have some feedback on new strings as well.

          Show
          Rajesh Taneja added a comment - Thanks for the feedback Glenn, You are right, I should have used third parameter, rather then concatenation. Have updated the branches with proper params. It will be helpful, to have some feedback on new strings as well.
          Hide
          Glenn Ansley added a comment -

          Looks good. The only thing I am unclear about - and I don't know the solution - is the different uses of the semicolons. They are used differently on lines 43 and 44 in the lang file than on lines 39, 41, 57, and 58. That my be by design though.

          Show
          Glenn Ansley added a comment - Looks good. The only thing I am unclear about - and I don't know the solution - is the different uses of the semicolons. They are used differently on lines 43 and 44 in the lang file than on lines 39, 41, 57, and 58. That my be by design though.
          Hide
          Rajesh Taneja added a comment -

          Hello Glenn,

          First two strings are for conditional activities which get updated when condition is met and hence text is like

          {Module_name}; not completed
          {Module_name}; completed
          

          Other two is for manual completion, so will need more info.

          Title
          {Module_name}; mark as complete
          Alt text
          {Module_name} is not completed; select to mark as complete'
          
          Show
          Rajesh Taneja added a comment - Hello Glenn, First two strings are for conditional activities which get updated when condition is met and hence text is like {Module_name}; not completed {Module_name}; completed Other two is for manual completion, so will need more info. Title {Module_name}; mark as complete Alt text {Module_name} is not completed; select to mark as complete'
          Hide
          Glenn Ansley added a comment -

          Cool. Sounds good.

          Show
          Glenn Ansley added a comment - Cool. Sounds good.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Rajesh Taneja added a comment -

          Branches re-based.

          Show
          Rajesh Taneja added a comment - Branches re-based.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is going to be delayed to next week...

          In the mean time, from one Spanish-minded guy (so accept my ignorance)... are those semicolons correct English? They don't look correct for me in that context. I'd use simple "." (dot), as far as phrases seem unrelated. Or alternatively, join them with some complement or use parenthesis, or other solutions, but the semi-colons...

          I'm adding Helen here... and one link to the file that surprised me, showing a bunch of semicolons:

          https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-30817#L2R35

          For your consideration, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This is going to be delayed to next week... In the mean time, from one Spanish-minded guy (so accept my ignorance)... are those semicolons correct English? They don't look correct for me in that context. I'd use simple "." (dot), as far as phrases seem unrelated. Or alternatively, join them with some complement or use parenthesis, or other solutions, but the semi-colons... I'm adding Helen here... and one link to the file that surprised me, showing a bunch of semicolons: https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-30817#L2R35 For your consideration, ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday, with point releases happening next week based on current status.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday, with point releases happening next week based on current status. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Helen Foster added a comment -

          Hi, and thanks for asking my opinion on these lang strings.

          After searching the Internet for a definitive guide on semicolon usage and finding http://theoatmeal.com/comics/semicolon here are my thoughts:

          '{$a} is not completed; select to mark as complete' is fine. Also fine would be:

          '{$a} is not completed. Select to mark as complete.'

          (Similarly for '{$a} is completed; select to mark as not complete')

          '{$a}; not completed' is wrong. I'd suggest

          '{$a} is not completed' or
          '{$a} not completed'

          (Similarly for '{$a}; completed')

          '{$a}; mark as complete' is also wrong. I'd suggest

          'Mark as complete: {$a}' or
          '{$a} - mark as complete'

          (Similarly for '{$a}; mark as not complete')

          Show
          Helen Foster added a comment - Hi, and thanks for asking my opinion on these lang strings. After searching the Internet for a definitive guide on semicolon usage and finding http://theoatmeal.com/comics/semicolon here are my thoughts: '{$a} is not completed; select to mark as complete' is fine. Also fine would be: '{$a} is not completed. Select to mark as complete.' (Similarly for '{$a} is completed; select to mark as not complete') '{$a}; not completed' is wrong. I'd suggest '{$a} is not completed' or '{$a} not completed' (Similarly for '{$a}; completed') '{$a}; mark as complete' is also wrong. I'd suggest 'Mark as complete: {$a}' or '{$a} - mark as complete' (Similarly for '{$a}; mark as not complete')
          Hide
          Rajesh Taneja added a comment -

          Thanks Eloy and Helen,

          I was thinking about this and it seems, it will be nice to have some consistency in these strings. Can you please confirm, if following is correct:
          '{$a} is not completed; select to mark as complete'
          Select to mark as complete. You have not completed: {$a}

          '{$a}; not completed'
          Completed: {$a}

          '{$a}; mark as complete'
          Mark as complete: {$a}

          Show
          Rajesh Taneja added a comment - Thanks Eloy and Helen, I was thinking about this and it seems, it will be nice to have some consistency in these strings. Can you please confirm, if following is correct: '{$a} is not completed; select to mark as complete' Select to mark as complete. You have not completed: {$a} '{$a}; not completed' Completed: {$a} '{$a}; mark as complete' Mark as complete: {$a}
          Hide
          Helen Foster added a comment -

          Hi Raj,

          The only problem is 'Select to mark as complete. You have not completed: {$a}' which doesn't quite make sense with the phrases swapped around. How about:

          'Completed: {$a}. Select to mark as not complete.'
          'Not completed: {$a}. Select to mark as complete.'

          'Completed: {$a}'
          'Not completed: {$a}'

          'Mark as complete: {$a}'
          'Mark as not complete: {$a}'

          Show
          Helen Foster added a comment - Hi Raj, The only problem is 'Select to mark as complete. You have not completed: {$a}' which doesn't quite make sense with the phrases swapped around. How about: 'Completed: {$a}. Select to mark as not complete.' 'Not completed: {$a}. Select to mark as complete.' 'Completed: {$a}' 'Not completed: {$a}' 'Mark as complete: {$a}' 'Mark as not complete: {$a}'
          Hide
          Rajesh Taneja added a comment -

          Thanks Helen, All branches updated with suggested strings

          Show
          Rajesh Taneja added a comment - Thanks Helen, All branches updated with suggested strings
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some hours ago...

          the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Rajesh Taneja added a comment -

          Branches re-based.

          Show
          Rajesh Taneja added a comment - Branches re-based.
          Hide
          Aparup Banerjee added a comment -

          Thanks for this fix, its been integrated into master, 22 and 21.

          Tester: i think you can also hover your mouse on the checkbox for alt texts.

          ps: Raj, noticed that you used 'activity_completion' in git msg - just want to say i think without underscore is fine too.

          Show
          Aparup Banerjee added a comment - Thanks for this fix, its been integrated into master, 22 and 21. Tester: i think you can also hover your mouse on the checkbox for alt texts. ps: Raj, noticed that you used 'activity_completion' in git msg - just want to say i think without underscore is fine too.
          Hide
          Michael de Raadt added a comment -

          Test result: Success.

          Tested under 2.1, 2.2 and master.

          During testing I noticed that when the icons for completion were updated in Moodle 2.1, the icons for auto and manual completion switched. I will need to ask Sam Marshall about that and see if it was deliberate.

          Show
          Michael de Raadt added a comment - Test result: Success. Tested under 2.1, 2.2 and master. During testing I noticed that when the icons for completion were updated in Moodle 2.1, the icons for auto and manual completion switched. I will need to ask Sam Marshall about that and see if it was deliberate.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          FCT (fixed, closing, thanks). Ciao

          "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
          ~ Benjamin Disraeli

          Show
          Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli
          Hide
          Dan Poltawski added a comment -

          Note that this issue caused a regression reported in: MDL-32535

          Show
          Dan Poltawski added a comment - Note that this issue caused a regression reported in: MDL-32535

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: