Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.1.5
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide
      1. Add a scorm package to a course and submit a few attempts from various students accounts
      2. Goto Scorm>Reports as admin/teacher
      3. Select 'all users' from the settings and save
      4. In top navigation bar (appears only when there are more than 20 users in total) select a firstname such that no user should be reported
      5. Make sure you still can see the preferences form and the First name/last name navigation bar
      6. Delete all attempts and change settings to "users with attempts" and save
      7. Make sure you still can see the preferences form
      Show
      Add a scorm package to a course and submit a few attempts from various students accounts Goto Scorm>Reports as admin/teacher Select 'all users' from the settings and save In top navigation bar (appears only when there are more than 20 users in total) select a firstname such that no user should be reported Make sure you still can see the preferences form and the First name/last name navigation bar Delete all attempts and change settings to "users with attempts" and save Make sure you still can see the preferences form
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Rank:
      33762

      Description

      The structure of Scorm report is completely different in 2.1 and 2.2 onwards, hence the changes made in MDL-30652 needs to be back-ported to 2.1 as well

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          @integrators
          21 only
          Thanks

          Show
          Ankit Agarwal added a comment - @integrators 21 only Thanks
          Hide
          Andrew Davis added a comment -

          2 little things.

          This comment "// Show preferences form irrespective of attempts are there to report or not" sounds like it should probably be something like "// Show the preferences form irrespective of whether there are attempts to report or not"

          Also, the section that starts with "if ($candelete && !$download) {" is double indented.

          Show
          Andrew Davis added a comment - 2 little things. This comment "// Show preferences form irrespective of attempts are there to report or not" sounds like it should probably be something like "// Show the preferences form irrespective of whether there are attempts to report or not" Also, the section that starts with "if ($candelete && !$download) {" is double indented.
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Andrew.
          I have made the changes.
          Sending to integration
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the review Andrew. I have made the changes. Sending to integration Thanks
          Hide
          Sam Hemelryk added a comment -

          Thanks Ankit, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Ankit, this has been integrated now.
          Hide
          Adrian Greeve added a comment -

          This doesn't get locked any more when there are not users to report in the scorm results. I couldn't find any problems.
          Thanks Ankit.

          Show
          Adrian Greeve added a comment - This doesn't get locked any more when there are not users to report in the scorm results. I couldn't find any problems. Thanks Ankit.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

          Closing as fixed, heading to zzzZZZzzz, niao

          Show
          Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: