Details

    • Testing Instructions:
      Hide
      1. Dock a couple of blocks
      2. Check that the docked block title still looks correct (not doubled up)
      3. In IE8 check that you get the title correctly as it is and check using a screenreader or development tool that the title is plain text rotated by CSS rather than an SVG
      4. In other browsers check that you get the SVG performing the rotation and that there is now an accesshide span containing the title as well.
      5. If you're really keen use a screen reader to confirm accessibility.
      Show
      Dock a couple of blocks Check that the docked block title still looks correct (not doubled up) In IE8 check that you get the title correctly as it is and check using a screenreader or development tool that the title is plain text rotated by CSS rather than an SVG In other browsers check that you get the SVG performing the rotation and that there is now an accesshide span containing the title as well. If you're really keen use a screen reader to confirm accessibility.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      wip-MDL-30830-m23
    • Rank:
      33830

      Description

      When a block is docked, it is taken out of the page headings because the heading text is rendered as an SVG text transform so the heading can be displayed as vertical text.

      Potential Solution:
      Render the heading as plain text off the screen or use a CSS3 transform. SVG support in assistive technologies is not good enough yet.

        Issue Links

          Activity

          Glenn Ansley created issue -
          Glenn Ansley made changes -
          Field Original Value New Value
          Fix Version/s 2.2.1 [ 11456 ]
          Glenn Ansley made changes -
          Component/s Accessibility [ 10083 ]
          Michael de Raadt made changes -
          Link This issue has been marked as being related by MDL-30831 [ MDL-30831 ]
          Michael de Raadt made changes -
          Fix Version/s DEV backlog [ 10464 ]
          Fix Version/s 2.2.1 [ 11456 ]
          Labels triaged
          Assignee moodle.com [ moodle.com ] Sam Hemelryk [ samhemelryk ]
          Component/s Navigation [ 10599 ]
          Hide
          Sam Hemelryk added a comment -

          Hi Glenn, thanks for the report.
          I've created a solution for this now and am putting it up for peer-review.
          I attempted to use CSS for the rotation of the title however it was fickle across browsers.
          As such the solution I have gone for is to add the title as a span within the h2 tag after the svg and then added the accesshide class to that span.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Glenn, thanks for the report. I've created a solution for this now and am putting it up for peer-review. I attempted to use CSS for the rotation of the title however it was fickle across browsers. As such the solution I have gone for is to add the title as a span within the h2 tag after the svg and then added the accesshide class to that span. Cheers Sam
          Sam Hemelryk made changes -
          Status Open [ 1 ] Waiting for peer review [ 10012 ]
          Pull Master Diff URL https://github.com/samhemelryk/moodle/compare/master...wip-MDL-30830-m23
          Pull Master Branch wip-MDL-30830-m23
          Pull from Repository git://github.com/samhemelryk/moodle.git
          Pull 2.1 Branch wip-MDL-30830-m21
          Pull 2.2 Diff URL https://github.com/samhemelryk/moodle/compare/MOODLE_22_STABLE...wip-MDL-30830-m22
          Pull 2.1 Diff URL https://github.com/samhemelryk/moodle/compare/MOODLE_21_STABLE...wip-MDL-30830-m21
          Pull 2.2 Branch wip-MDL-30830-m22
          Michael de Raadt made changes -
          Fix Version/s STABLE Sprint 17 [ 11550 ]
          Fix Version/s DEV backlog [ 10464 ]
          Andrew Davis made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Peer reviewer andyjdavis
          Hide
          Andrew Davis added a comment -

          The code change looks simple enough. This needs testing instructions.

          Show
          Andrew Davis added a comment - The code change looks simple enough. This needs testing instructions.
          Andrew Davis made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, putting this up for integration now.

          Show
          Sam Hemelryk added a comment - Thanks Andrew, putting this up for integration now.
          Sam Hemelryk made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Testing Instructions # Dock a couple of blocks
          # Check that the docked block title still looks correct (not doubled up)
          # In IE8 check that you get the title correctly as it is and check using a screenreader or development tool that the title is plain text rotated by CSS rather than an SVG
          # In other browsers check that you get the SVG performing the rotation and that there is now an accesshide span containing the title as well.
          # If you're really keen use a screen reader to confirm accessibility.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (21, 22 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master), thanks!
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.2.1 [ 11456 ]
          Affects Version/s 2.3 [ 10657 ]
          Michael de Raadt made changes -
          Tester abgreeve
          Hide
          Adrian Greeve added a comment - - edited

          I tested this using NVDA Speech Viewer. IE picks up the docked tab just fine, Chrome will read it as well, but I couldn't get firefox to work.
          I checked with firebug and the code produces a span with a description of the block. I'd say that besides the fact that the speech viewer that I used didn't recognize the text, that it works fine.

          Some further advice on how to proceed would be most appreciated

          Show
          Adrian Greeve added a comment - - edited I tested this using NVDA Speech Viewer. IE picks up the docked tab just fine, Chrome will read it as well, but I couldn't get firefox to work. I checked with firebug and the code produces a span with a description of the block. I'd say that besides the fact that the speech viewer that I used didn't recognize the text, that it works fine. Some further advice on how to proceed would be most appreciated
          Adrian Greeve made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Sam Hemelryk added a comment -

          Hi Adrian,

          I think that given this has passing in IE and Chrome and that you can confirm the span is at least there in Firefox this should be passed.
          I've no clue why it isn't working in NVDA and there are likely too many variables to be ultimately sure.
          Ideally Glenn if you or the users you got to do the original testing could test it once more that would be great.
          I imagine you probably don't want to rerun the tests for every single issue individually though so for the time being I think marking this passed and then filing a new bug should it prove to not work in situations would be the way to go.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Adrian, I think that given this has passing in IE and Chrome and that you can confirm the span is at least there in Firefox this should be passed. I've no clue why it isn't working in NVDA and there are likely too many variables to be ultimately sure. Ideally Glenn if you or the users you got to do the original testing could test it once more that would be great. I imagine you probably don't want to rerun the tests for every single issue individually though so for the time being I think marking this passed and then filing a new bug should it prove to not work in situations would be the way to go. Cheers Sam
          Hide
          Adrian Greeve added a comment -

          Thanks Sam. Passing this test.

          Show
          Adrian Greeve added a comment - Thanks Sam. Passing this test.
          Adrian Greeve made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some changes to Moodle should be milestones in the project by themselves.

          This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 23/Feb/12
          Hide
          Greg Kraus added a comment -

          This works fine in NVDA. Thanks all!

          Show
          Greg Kraus added a comment - This works fine in NVDA. Thanks all!
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s STABLE Sprint 17 [ 11550 ]

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: