Moodle
  1. Moodle
  2. MDL-27843 META: Accessibility compliance for 2.x
  3. MDL-30831

Content of docked blocks are not accessible to screen readers. There is no prompt highlighting expandable items.

    Details

    • Testing Instructions:
      Hide
      1. Log in as Admin
      2. doc few blocks
      3. Make sure dock panel has role=menubar
      4. on docked blocks role should be menu, aria-haspopup=true, aria-expanded=false
      5. When expanded it should change to aria-expanded= true

      Test with screen-reader and try see if dock menu is accessible

      Show
      Log in as Admin doc few blocks Make sure dock panel has role=menubar on docked blocks role should be menu, aria-haspopup=true, aria-expanded=false When expanded it should change to aria-expanded= true Test with screen-reader and try see if dock menu is accessible
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-30831

      Description

      When a block is docked, screen reader users cannot access the contents of the block. Technically, it is possible for a screen reader user to access the contents of a docked block if the user knows exactly how the page is laid out, but Moodle does not give any indications or clues as to how to access the block's contents. Blocks must be undocked for the screen reader users to effectively access them.

      Potential Solution:
      Use ARIA to denote that it is a menu with an expandable submenu

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Jason Fowler added a comment -

            Looks great Raj, Testing will also need to be done in a screen reader to ensure it is working as intended.

            Show
            Jason Fowler added a comment - Looks great Raj, Testing will also need to be done in a screen reader to ensure it is working as intended.
            Hide
            Rajesh Taneja added a comment -

            Hello Jason,

            I tried screen reader and it didn't show anything. Not sure if I missed anything.

            Show
            Rajesh Taneja added a comment - Hello Jason, I tried screen reader and it didn't show anything. Not sure if I missed anything.
            Hide
            Jason Fowler added a comment -

            just check for regression in NVDA or JAWS I guess

            Show
            Jason Fowler added a comment - just check for regression in NVDA or JAWS I guess
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Rajesh Taneja added a comment -

            Branches re-based.

            Show
            Rajesh Taneja added a comment - Branches re-based.
            Hide
            Dan Poltawski added a comment -

            Thanks Raj, thats integrated now to 22, 23 and master.

            Show
            Dan Poltawski added a comment - Thanks Raj, thats integrated now to 22, 23 and master.
            Hide
            Dan Poltawski added a comment -

            Ankit can't seen an improvement in this issue in the screenreader he is trying. I have asked to revert to a regression test in the normal interface, rather than revert this..

            Show
            Dan Poltawski added a comment - Ankit can't seen an improvement in this issue in the screenreader he is trying. I have asked to revert to a regression test in the normal interface, rather than revert this..
            Hide
            Ankit Agarwal added a comment -

            This adds the aria attributes properly.
            Although the docked menu bar, is still completely inaccessible using NVDA screen reader.
            I don't see any regressions.

            Passing it based on Dan's advice.

            Thanks

            Show
            Ankit Agarwal added a comment - This adds the aria attributes properly. Although the docked menu bar, is still completely inaccessible using NVDA screen reader. I don't see any regressions. Passing it based on Dan's advice. Thanks
            Hide
            Dan Poltawski added a comment -

            Congratulations, you've done it!

            Thanks, this change is now in the latest weekly release!

            Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

            Show
            Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: