Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27843 META: Accessibility compliance for 2.x
  3. MDL-30833

Provide feedback to screen readers that the navigation block is expandable / collapsible

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Inspect navigation and settings block with firebug
      3. Make sure nodes have proper aria-expanded = true (when expanded) and false when collapsed.

      Check with screen reader and see if it's accessible.

      Show
      Log in as admin Inspect navigation and settings block with firebug Make sure nodes have proper aria-expanded = true (when expanded) and false when collapsed. Check with screen reader and see if it's accessible.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-mdl-30833

      Description

      There is no indication to screen reader users that a node is expandable or collapsible

      Potential Solution:
      Use ARIA to define a tree with expandable nodes

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              phalacee Jason Fowler added a comment -

              again, this will need to be tested in a screen reader before we can be sure it is working, but the code seems to solve this issue.

              Show
              phalacee Jason Fowler added a comment - again, this will need to be tested in a screen reader before we can be sure it is working, but the code seems to solve this issue.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks Jason, updated test instructions.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks Jason, updated test instructions.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Branches re-based

              Show
              rajeshtaneja Rajesh Taneja added a comment - Branches re-based
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Raj,

              Please could you add spaces around the opreators in your use of the ternary operator, see:
              http://docs.moodle.org/dev/Coding_style#Ternary_Operator

              Show
              poltawski Dan Poltawski added a comment - Hi Raj, Please could you add spaces around the opreators in your use of the ternary operator, see: http://docs.moodle.org/dev/Coding_style#Ternary_Operator
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks Dan,

              It's done.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks Dan, It's done.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Raj,

              You've missed one of them in blocks/navigation/renderer.php

              Show
              poltawski Dan Poltawski added a comment - Hi Raj, You've missed one of them in blocks/navigation/renderer.php
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              grrr...
              Sorry Dan... Fixed now...

              Show
              rajeshtaneja Rajesh Taneja added a comment - grrr... Sorry Dan... Fixed now...
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Raj, integrated to 22, 23 and master.

              Show
              poltawski Dan Poltawski added a comment - Thanks Raj, integrated to 22, 23 and master.
              Hide
              dmonllao David Monllaó added a comment -

              It passes, tested in:

              • Chrome + linux
              • Firefox + Windows 7 (with NVDA)

              I can see how the aria-expanded attribute changes when expanding/collapsing

              Show
              dmonllao David Monllaó added a comment - It passes, tested in: Chrome + linux Firefox + Windows 7 (with NVDA) I can see how the aria-expanded attribute changes when expanding/collapsing
              Hide
              poltawski Dan Poltawski added a comment -

              Congratulations, you've done it!

              Thanks, this change is now in the latest weekly release!

              Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

              Show
              poltawski Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Hi guys,

              I've just opened MDL-35590 as a regression caused by this issue.
              The aria-expanded attribute must be applied on elements having or inheriting from an element with one of the suitable roles: http://www.w3.org/TR/wai-aria/states_and_properties#aria-expanded

              It appears that when not applied within the required roles they are ignored (so says the spec, browser implementation may alter of course).
              It also causes the page to fail validation.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Hi guys, I've just opened MDL-35590 as a regression caused by this issue. The aria-expanded attribute must be applied on elements having or inheriting from an element with one of the suitable roles: http://www.w3.org/TR/wai-aria/states_and_properties#aria-expanded It appears that when not applied within the required roles they are ignored (so says the spec, browser implementation may alter of course). It also causes the page to fail validation. Cheers Sam

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12