Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30835

Bullets are hidden in high contrast mode

    Details

      Description

      In high contrast mode in Windows the custom bullets do not appear because they are rendered as background images

      Potential Solution:
      Images that convey important information should be coded in the HTML, not as CSS background images

        Gliffy Diagrams

          Issue Links

            Activity

            blepoxp Glenn Ansley created issue -
            blepoxp Glenn Ansley made changes -
            Field Original Value New Value
            Fix Version/s 2.2.1 [ 11456 ]
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Fix Version/s 2.2.1 [ 11456 ]
            Labels triaged
            Assignee moodle.com [ moodle.com ] Mary Evans [ lazydaisy ]
            Component/s Themes [ 10088 ]
            salvetore Michael de Raadt made changes -
            Assignee Mary Evans [ lazydaisy ] Sam Hemelryk [ samhemelryk ]
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hmmm just looking and thinking about this.

            It represents a huge change, one that would not be backwards compatible and thus wouldn't be suitable for anything but master.
            Unfortunately I havn't thought up any other solutions either but I will continue to think about it.

            Show
            samhemelryk Sam Hemelryk added a comment - Hmmm just looking and thinking about this. It represents a huge change, one that would not be backwards compatible and thus wouldn't be suitable for anything but master. Unfortunately I havn't thought up any other solutions either but I will continue to think about it.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            I've been playing with this over the past day.

            I had the idea of using the background images as the list item images (presently the navigation is a list), however that idea hasn't panned out due to the way in which browsers handle click events on list items (they select all content within the list item).
            We could convert the background images to HTML image tags, however that would break existing themes.
            I've decided not to tackle that as part of this issue, the reason being twofold.

            1. There are several other issues that can be combined here that require changes that would not work with other themes.
            2. Its too close to the release of 2.4 and such a change would not be accepted at this late stage in development.

            Instead I have opened MDL-36016 to address the larger issue of redesigning the navigation and settings blocks.
            I will leave this open for the time being and will close this issue when we know it has been addressed by MDL-36016.

            Many thanks
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - I've been playing with this over the past day. I had the idea of using the background images as the list item images (presently the navigation is a list), however that idea hasn't panned out due to the way in which browsers handle click events on list items (they select all content within the list item). We could convert the background images to HTML image tags, however that would break existing themes. I've decided not to tackle that as part of this issue, the reason being twofold. There are several other issues that can be combined here that require changes that would not work with other themes. Its too close to the release of 2.4 and such a change would not be accepted at this late stage in development. Instead I have opened MDL-36016 to address the larger issue of redesigning the navigation and settings blocks. I will leave this open for the time being and will close this issue when we know it has been addressed by MDL-36016 . Many thanks Sam
            samhemelryk Sam Hemelryk made changes -
            Link This issue will be resolved by MDL-36016 [ MDL-36016 ]
            salvetore Michael de Raadt made changes -
            Parent MDL-27843 [ 44849 ]
            Issue Type Sub-task [ 5 ] Bug [ 1 ]
            salvetore Michael de Raadt made changes -
            Epic Link MDL-27843 [ 44849 ]
            salvetore Michael de Raadt made changes -
            Fix Version/s FRONTEND [ 12581 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Hide
            salvetore Michael de Raadt added a comment -

            I'm shifting this issue into a new Epic issue, where we are collecting together accessibility issues.

            Show
            salvetore Michael de Raadt added a comment - I'm shifting this issue into a new Epic issue, where we are collecting together accessibility issues.
            salvetore Michael de Raadt made changes -
            Epic Link MDL-27843 [ 44849 ] MDL-40738 [ 68016 ]
            Hide
            samhemelryk Sam Hemelryk added a comment -

            I am un-assigning myself from this issue as I am not currently working on this and it will give the opportunity for someone else to work on it.

            Show
            samhemelryk Sam Hemelryk added a comment - I am un-assigning myself from this issue as I am not currently working on this and it will give the opportunity for someone else to work on it.
            samhemelryk Sam Hemelryk made changes -
            Assignee Sam Hemelryk [ samhemelryk ]
            Hide
            lazydaisy Mary Evans added a comment -

            Just wondering what are 'custom' bullets? Are we talking navigation icons or fonts?

            Show
            lazydaisy Mary Evans added a comment - Just wondering what are 'custom' bullets? Are we talking navigation icons or fonts?

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: