Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30857

Clicking on comments in the community viewer block doesn't display any comments in IE8

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Blocks, Hub
    • Labels:
    • Environment:
      Windows 7 Home Basic, Internet Explorer 8.0.7600.16385
    • Testing Instructions:
      Hide

      This issue should be tested in different browsers, specially in IE family.

      1. Login as an admin user
      2. Add the "Community finder" block to moodle frontpage
      3. Click "Search" on the community finder block
      4. Browse through the databases until you find a course with comments (I've found courses with comments in MOOCH + find: courses I can download + keywords: water)
      5. Click on the "Comments (N)" you SHOULD be able to see a emerging overlay with the size of the text it contains
      Show
      This issue should be tested in different browsers, specially in IE family. Login as an admin user Add the "Community finder" block to moodle frontpage Click "Search" on the community finder block Browse through the databases until you find a course with comments (I've found courses with comments in MOOCH + find: courses I can download + keywords: water) Click on the "Comments (N)" you SHOULD be able to see a emerging overlay with the size of the text it contains
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30857_master

      Description

      Make sure that you are using Internet Explorer 8

      1) Add the community finder block.
      2) Do a search (MOOCH is good).
      3) Select either courses I can enroll in or courses I can download then search.
      4) Scroll down and find a course with a comment. Click and view.

      In Internet Explorer 8 a box pops up but no comments are displayed.

        Gliffy Diagrams

          Issue Links

            Activity

            abgreeve Adrian Greeve created issue -
            abgreeve Adrian Greeve made changes -
            Field Original Value New Value
            Attachment comments.png [ 26216 ]
            abgreeve Adrian Greeve made changes -
            Link This issue discovered while testing MDL-30627 [ MDL-30627 ]
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            Assignee moodle.com [ moodle.com ] Jerome Mouneyrac [ jerome ]
            Affects Version/s 2.3 [ 10657 ]
            Component/s Hub [ 10609 ]
            Hide
            dmonllao David Monllaó added a comment -

            Hi Jerome,

            I've discovered the issue while working on another issue, is still present in master, addding pull branches with proposed patch

            Show
            dmonllao David Monllaó added a comment - Hi Jerome, I've discovered the issue while working on another issue, is still present in master, addding pull branches with proposed patch
            Hide
            jerome Jérôme Mouneyrac added a comment - - edited

            If it works on other browsers too, you can submit to integration. Thanks.

            Show
            jerome Jérôme Mouneyrac added a comment - - edited If it works on other browsers too, you can submit to integration. Thanks.
            jerome Jérôme Mouneyrac made changes -
            Assignee Jerome Mouneyrac [ jerome ] David Monllaó [ davmon ]
            dmonllao David Monllaó made changes -
            Testing Instructions This issue should be tested in different browsers, specially in IE family.

            # Login as an admin user
            # Add the "Community finder" block to moodle frontpage
            # Click "Search" on the community finder block
            # Browse through the databases until you find a course with comments (I've found courses with comments in MOOCH + find: courses I can download + keywords: water)
            # Click on the "Comments (N)" you SHOULD be able to see a emerging overlay with the size of the text it contains
            Hide
            dmonllao David Monllaó added a comment -

            Thanks Jerome, submitting for integration, tested with:

            • Windows
              • Chrome 21.0.1180.89
              • IE 8
              • Firefox 15.0
              • Opera 12.02
              • Safari 5.1.7
            • Linux
              • Firefox 15.0
              • Chrome 21.0.1180.89
            Show
            dmonllao David Monllaó added a comment - Thanks Jerome, submitting for integration, tested with: Windows Chrome 21.0.1180.89 IE 8 Firefox 15.0 Opera 12.02 Safari 5.1.7 Linux Firefox 15.0 Chrome 21.0.1180.89
            dmonllao David Monllaó made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks David, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks David, this has been integrated now
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.2.6 [ 12372 ]
            Fix Version/s 2.3.3 [ 12373 ]
            Fix Version/s STABLE backlog [ 10463 ]
            timb Tim Barker made changes -
            Tester salvetore
            timb Tim Barker made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester salvetore timb
            Hide
            timb Tim Barker added a comment -

            Tested on IE8 and 9, Safari, Chrome and Firefox. It's all awesome

            Show
            timb Tim Barker added a comment - Tested on IE8 and 9, Safari, Chrome and Firefox. It's all awesome
            timb Tim Barker made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 14/Sep/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12