Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30865

Unreliable way of aggregate_grading_grades_process() unit testing

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.3, 2.2, 2.3
    • 2.1.4, 2.2.1
    • Workshop
    • None
    • Any
    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • Hide

      Run unit tests in /mod/workshop several times and make sure they pass always.

      Show
      Run unit tests in /mod/workshop several times and make sure they pass always.

    Description

      The method aggregate_grading_grades_process() creates or updates DB records containing the actual timestamp. However, the value of this timestamp can't be checked by the caller in any way. So the unit test may fail from time to time (and it does as new Eloy's CI toy reveal).

      Attachments

        Activity

          People

            mudrd8mz David Mudrák (@mudrd8mz)
            mudrd8mz David Mudrák (@mudrd8mz)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Ankit Agarwal Ankit Agarwal
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/Jan/12