Moodle
  1. Moodle
  2. MDL-30865

Unreliable way of aggregate_grading_grades_process() unit testing

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Workshop
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      Run unit tests in /mod/workshop several times and make sure they pass always.

      Show
      Run unit tests in /mod/workshop several times and make sure they pass always.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Rank:
      33867

      Description

      The method aggregate_grading_grades_process() creates or updates DB records containing the actual timestamp. However, the value of this timestamp can't be checked by the caller in any way. So the unit test may fail from time to time (and it does as new Eloy's CI toy reveal).

        Activity

        Hide
        David Mudrak added a comment -

        INTEGRATORS, please cherry-pick this onto 2.0, 2.1 and master too. Let me know if cherry-picking fails and I'll deal with it.

        Show
        David Mudrak added a comment - INTEGRATORS, please cherry-pick this onto 2.0, 2.1 and master too. Let me know if cherry-picking fails and I'll deal with it.
        Hide
        David Mudrak added a comment -

        Ping for Eloy - this should fix the occasional workshop tests fail. Thanks for raising this.

        Show
        David Mudrak added a comment - Ping for Eloy - this should fix the occasional workshop tests fail. Thanks for raising this.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (21, 22 and master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 and master), thanks!
        Hide
        Ankit Agarwal added a comment -

        This is working great

        6/6 test cases complete: 107 passes, 0 fails and 0 exceptions.
        

        Passing!
        Thanks

        Show
        Ankit Agarwal added a comment - This is working great 6/6 test cases complete: 107 passes, 0 fails and 0 exceptions. Passing! Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: