Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30865

Unreliable way of aggregate_grading_grades_process() unit testing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Workshop
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      Run unit tests in /mod/workshop several times and make sure they pass always.

      Show
      Run unit tests in /mod/workshop several times and make sure they pass always.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:

      Description

      The method aggregate_grading_grades_process() creates or updates DB records containing the actual timestamp. However, the value of this timestamp can't be checked by the caller in any way. So the unit test may fail from time to time (and it does as new Eloy's CI toy reveal).

        Attachments

          Activity

            People

            • Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/12