Moodle
  1. Moodle
  2. MDL-30867

Lesson essay question formatting is inconsistent and in fact horribly broken.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide
      1. As a teacher create a lesson with a single essay question.
      2. Log in as a user one and set the users htmleditor preference to use the HTML editor.
      3. Enter the lesson and create an answer using a couple of different styles within the editor (e.g. bold, italic etc).
      4. Log out.
      5. Log in as user two and set the users htmleditor preference to use standard web forms.
      6. Enter the lesson and set the format for the answer to plain text format and create and answer with all sorts of HTML and Moodle formatting in it.
      7. Log out.
      8. Log in as user three and set the users htmleditor preference to use standard web forms.
      9. Enter the lesson and set the format for the answer to Moodle format and create and answer with all sorts of HTML and Moodle formatting in it.
      10. Log out.
      11. Log in as the teacher
      12. Browse to the lesson reports tab and for each user inspect the answer
        • User 1 should be HTML and the moodle formatting won't have been converted
        • User 2 should be HTML and the moodle formatting will have been converting
        • User 3 should be plain text with HTML and moodle formatting having been encoded but not converted.
      13. Browse to the Grade essays tab
      14. Inspect each users answers to make sure they match the above.
      Show
      As a teacher create a lesson with a single essay question. Log in as a user one and set the users htmleditor preference to use the HTML editor. Enter the lesson and create an answer using a couple of different styles within the editor (e.g. bold, italic etc). Log out. Log in as user two and set the users htmleditor preference to use standard web forms. Enter the lesson and set the format for the answer to plain text format and create and answer with all sorts of HTML and Moodle formatting in it. Log out. Log in as user three and set the users htmleditor preference to use standard web forms. Enter the lesson and set the format for the answer to Moodle format and create and answer with all sorts of HTML and Moodle formatting in it. Log out. Log in as the teacher Browse to the lesson reports tab and for each user inspect the answer User 1 should be HTML and the moodle formatting won't have been converted User 2 should be HTML and the moodle formatting will have been converting User 3 should be plain text with HTML and moodle formatting having been encoded but not converted. Browse to the Grade essays tab Inspect each users answers to make sure they match the above.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
    • Rank:
      33869

      Description

      While reviewing MDL-30639 we noted that the essay question type in the lesson module does not store the format the user used while answering it.
      Because of this essay questions are consistently mis-formatted throughout Moodle.

      The lesson module needs to be somehow storing the answer formated used by a user and then use it consistently when displaying the users answer.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          I'm making this issue critical.
          We can't get back the format information, it's lost immediately when the user saves.
          The sooner we get this in the sooner we can start formatting properly.
          It will also make it a little more difficult to upgrade.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - I'm making this issue critical. We can't get back the format information, it's lost immediately when the user saves. The sooner we get this in the sooner we can start formatting properly. It will also make it a little more difficult to upgrade. Cheers Sam
          Hide
          Ankit Agarwal added a comment -

          Hi Rosie,
          Looks good to me.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Rosie, Looks good to me. Thanks
          Hide
          Rossiani Wijaya added a comment -

          Thanks Ankit for reviewing.

          Submitting this for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Ankit for reviewing. Submitting this for integration review.
          Hide
          Aparup Banerjee added a comment -

          Thanks, hopefully not to much data has been lost out there.

          integrated into master, 22 and 21. Ready for testing!

          Show
          Aparup Banerjee added a comment - Thanks, hopefully not to much data has been lost out there. integrated into master, 22 and 21. Ready for testing!
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, passing this test now

          Show
          Sam Hemelryk added a comment - Thanks guys, passing this test now
          Hide
          Eloy Lafuente (stronk7) added a comment -

          FCT (fixed, closing, thanks). Ciao

          "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
          ~ Benjamin Disraeli

          Show
          Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: