Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.1.3, 2.2
    • Fix Version/s: 2.2.1
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      To test this you will first need to have an online assignment set up in a course and be able to access it as a student.

      1. Select Boxxie theme
      2. Enter the 'Online Assignment' to either submit a new assignment or edit an existing one
      3. Check to see that the HTML Editor is fully visible.
      Show
      To test this you will first need to have an online assignment set up in a course and be able to access it as a student. Select Boxxie theme Enter the 'Online Assignment' to either submit a new assignment or edit an existing one Check to see that the HTML Editor is fully visible.
    • Workaround:
      Hide

      This is a CSS issue and easily fixed

      Show
      This is a CSS issue and easily fixed
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      33871

      Description

      See discussion in Themes forum...

      http://moodle.org/mod/forum/discuss.php?d=192761

        Issue Links

          Activity

          Hide
          Mary Evans added a comment - - edited

          @Sam or whoever gets to integrate this.

          It appears that my text editor has a mind of its own and has cleaned up some white spaces in the file I submitted here, which detracts slightly from the changes that I actually made to fix this bug. I also noticed a small error @line 227 which read margin:0auto; which I corrected to read: margin: 0 auto; I hope this is OK?

          With regards the actual BUG, I am surprised that it has not been reported before now, as it is clearly impossible to either submit or edit an 'Online Assignment' in Boxxie theme.

          I am also wondering is there is a need for the boilerplate.css in this theme? There is also one in Canvas theme which I have often wondered why it's there as it does not appear to be listed in config or anywhere else for that matter.

          Ok that's that...

          Happy Christmas Everyone!

          Mary

          Show
          Mary Evans added a comment - - edited @Sam or whoever gets to integrate this. It appears that my text editor has a mind of its own and has cleaned up some white spaces in the file I submitted here, which detracts slightly from the changes that I actually made to fix this bug. I also noticed a small error @line 227 which read margin:0auto; which I corrected to read: margin: 0 auto; I hope this is OK? With regards the actual BUG, I am surprised that it has not been reported before now, as it is clearly impossible to either submit or edit an 'Online Assignment' in Boxxie theme. I am also wondering is there is a need for the boilerplate.css in this theme? There is also one in Canvas theme which I have often wondered why it's there as it does not appear to be listed in config or anywhere else for that matter. Ok that's that... Happy Christmas Everyone! Mary
          Hide
          Mary Evans added a comment -

          Sam,
          Just been hearing about the earthquakes in NZ and knowing that's where you are, just hope you and your family are safe.
          God bless

          Show
          Mary Evans added a comment - Sam, Just been hearing about the earthquakes in NZ and knowing that's where you are, just hope you and your family are safe. God bless
          Hide
          Sam Hemelryk added a comment -

          Hi Mary,

          Thanks for your concern, we've had quite the rough Christmas over here.
          The earthquakes were in Christchurch, south of where I live so I was fine, I do have family there but luckily they are all alright as well.
          I hope you had a good Christmas and new years?

          I've looked over your changes and all look spot on, no probs about the white space changes

          I'll integrate this during the next integration cycle, either today or tomorrow.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary, Thanks for your concern, we've had quite the rough Christmas over here. The earthquakes were in Christchurch, south of where I live so I was fine, I do have family there but luckily they are all alright as well. I hope you had a good Christmas and new years? I've looked over your changes and all look spot on, no probs about the white space changes I'll integrate this during the next integration cycle, either today or tomorrow. Cheers Sam
          Hide
          Mary Evans added a comment - - edited

          Happy New Year Sam!

          Glad to hear all is well with you.
          Yes thank you...I had a lovely Christmas & New Year.

          Thanks also for getting this integrated.
          I have a long TODO list of theme fixes to get through in the next few weeks time permitting of course.

          Some new ideas I have been discussing with Dietmar, but that's about reports and page layouts in general, which we will be working on shortly. But more about that in another tracker issue when I set it up.

          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited Happy New Year Sam! Glad to hear all is well with you. Yes thank you...I had a lovely Christmas & New Year. Thanks also for getting this integrated. I have a long TODO list of theme fixes to get through in the next few weeks time permitting of course. Some new ideas I have been discussing with Dietmar, but that's about reports and page layouts in general, which we will be working on shortly. But more about that in another tracker issue when I set it up. Cheers Mary
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary, this has been integrated.

          I'll look forward to seeing the theme changes

          Show
          Sam Hemelryk added a comment - Thanks Mary, this has been integrated. I'll look forward to seeing the theme changes
          Hide
          Rossiani Wijaya added a comment -

          This looks good.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This looks good. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: