I'm finally catching up with the pre-christmas issues.

Thanks for reporting that and providing a solution.

The file /lib/javascript-static.js is also generating security errors when using web fonts - some chrome plugins....
I modified the file (try catch block & extra null checking) and the mp3 player is showing up again in Firefox-Chrome-IE :

for (var j=0; j < document.styleSheets.length; j++) {
   var allrules = new Array();
   try {
      if (typeof (document.styleSheets[j].rules) != 'undefined') {
         allrules = document.styleSheets[j].rules;
      } else if (typeof (document.styleSheets[j].cssRules) != 'undefined') {
         allrules = document.styleSheets[j].cssRules;
      } else {
         // why??
         continue;
      }
      //chrome plugins - web fonts - ...
      if (allrules == null) {
         continue;
      }
              
      for(var i=0; i<allrules.length; i++) {
         rule = '';
         if (/^\.mp3flowplayer_.*Color$/.test(allrules[i].selectorText)) {
           if (typeof(allrules[i].cssText) != 'undefined') {
              rule = allrules[i].cssText;
           } else if (typeof(allrules[i].style.cssText) != 'undefined') {
              rule = allrules[i].style.cssText;
           }
           if (rule != '' && /.*color\s*:\s*([^;]+).*/gi.test(rule)) {
              rule = rule.replace(/.*color\s*:\s*([^;]+).*/gi, '$1');
              var colprop = allrules[i].selectorText.replace(/^\.mp3flowplayer_/, '');
              controls[colprop] = rule;
           }
         }
      }
      allrules = false;
   }
   catch (err) {
      //Houston, we have a security problem
      continue;
   }
}

Hi Renaat,

The attached patches https://github.com/dmonllao/moodle/compare/master...MDL-30876_master (for example) should solve your problem as well, can you please verify it or provide steps to reproduce your problem? Thanks in advance

The MDL-30876 patch solves MDL-32310 and MDL-32582, it includes the "allrules = null" checking

Thanks David,

Patch looks good to me, pushing it for integration review.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

This issue looked very familiar.
I integrated a fix for this earlier today MDL-32310.

David can you tell me, the try...catch that has been introduced here, is it required (do any browsers throw exceptions)?
If so then certainly this fix needs to be merged into the existing fix. If not then I think the current fix should be enough.

I'll leave this in integration until I've heard back from you David, and will ping Dan as well to get his thoughts.

Cheers
Sam

Hi Sam,

Yes, Firefox reports the exception and stops the JS execution, this patch includes the other one. Attaching exception thrown with the MDL-32310 patch applied

Awesome thanks for clarifying that David, I've merged these changes in now

works as expected.
Thanks

*Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

Congratulations

!

You've made into Moodle

+

I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

cheers!