Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.2
-
Component/s: Gradebook
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-30880_feedback_property -
Pull Master Diff URL:
-
Rank:33889
Description
Editing a grade for a non-core module in the gradebook, checking locked and then un-checking locked produces a PHP notice and prevents the page from redirecting automatically.
Reproduction steps:
- Log in as an admin/instructor
- Go into the course and click Grades
- Turn on editing
- Edit the grade for the non-core plug-in
- Check 'locked' and save
- Go back and edit that same grade
- Un-check 'locked' click save
- The page displays the following message
Notice: Undefined property: stdClass::$feedback in /var/www/html/ack/testsite/grade/edit/tree/grade.php on line 165 Call Stack: 0.0019 779336 1.
Unknown macro: {main}() /var/www/html/ack/testsite/grade/edit/tree/grade.php:0
Skip to main contentThis page should automatically redirect. If nothing is happening please use the continue link below.
(Continue)Error output, so disabling automatic redirect.
Here is the line of code that produces that notice message
if (is_array($data->feedback)) {
$data->feedbackformat = $data->feedback['format'];
$data->feedback = $data->feedback['text'];
}
The code should first check to see if the feedback property exists and then check to see if it is an array
if (isset($data->feedback) && is_array($data->feedback)) {
$data->feedbackformat = $data->feedback['format'];
$data->feedback = $data->feedback['text'];
}
The same thing happens when editing core graded modules but for some reason the notice message does not appear.
Activity
Adding testing instructions and a git branch containing the suggested fix. Putting this up for peer review. I'll create 2.2 and 2.1 versions once that's done.
Although it may get integrated before then Im adding this to the next stable sprint to make sure it doesn't get forgotten.
Thanks!
Hi Andrew,
Changes looks good and makes sense.
But I was not able to replicate this on master $data->feedback is always set for me. (Akin encountered it on non-contributed modules only as well). So it might be a good idea to update the testing instructions, to test this with some non-contributed core module.
Thanks
Adding 2.2 and 2.1 branches. I've updated the testing instructions to include testing with a contributed activity.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
Integrated, thanks Andrew
Success on 2.1, 2.2 and master!
We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.
Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.
Many thanks for your collaboration!
Ciao
Thanks for reporting that and providing a solution.