Details

    • Testing Instructions:
      Hide

      1. Add a calendar block on the main page if none is present
      2. Inspect the calendar <table> tag and make sure the summary attribute displays 'May 2012 Calendar'
      3. Go to the calendar month view (Click on the link 'May 2012')
      4. Again, inspect the calendar <table> tag and make sure the summary attribute displays 'May 2012 Calendar'

      Show
      1. Add a calendar block on the main page if none is present 2. Inspect the calendar <table> tag and make sure the summary attribute displays 'May 2012 Calendar' 3. Go to the calendar month view (Click on the link 'May 2012') 4. Again, inspect the calendar <table> tag and make sure the summary attribute displays 'May 2012 Calendar'
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30888-master
    • Rank:
      33897

      Description

      For the small calendars on the side of the page, either when viewing the main monthly calendar or in the calendar block, the table summaries do not need to include the text "Data table" in "Data table, December 2011 Calendar". Just have the summary read "December 2011 Calendar"

        Activity

        Hide
        Frédéric Massart added a comment -

        I decided to keep the string although it's now empty because we might want to use it in a later stage.

        Show
        Frédéric Massart added a comment - I decided to keep the string although it's now empty because we might want to use it in a later stage.
        Hide
        Sam Hemelryk added a comment -

        Hi Fred,

        I've just been having a look and a think about this now.
        Having thought about it I think the best approach is to alter the code in all branches to not use the string. Then in master remove the string completely, and in stable branches leave it exactly as it is now (we never remove strings from stable branches).

        Keeping a string just with {$a} doesn't make any sense, it involves a lot of processing for a string that requires no translation.
        Also helping that decision is that the string is probably in the wrong lang file as well, it only used within the calendar.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Fred, I've just been having a look and a think about this now. Having thought about it I think the best approach is to alter the code in all branches to not use the string. Then in master remove the string completely, and in stable branches leave it exactly as it is now (we never remove strings from stable branches). Keeping a string just with {$a} doesn't make any sense, it involves a lot of processing for a string that requires no translation. Also helping that decision is that the string is probably in the wrong lang file as well, it only used within the calendar. Cheers Sam
        Hide
        Frédéric Massart added a comment -

        Hey Sam. Just reflected your remarks in the branches. I reverted the string change in 2.1 and 2.2 but deleted the line using it. And I removed the string and the line from master. I also removed another unused string from master.

        Show
        Frédéric Massart added a comment - Hey Sam. Just reflected your remarks in the branches. I reverted the string change in 2.1 and 2.2 but deleted the line using it. And I removed the string and the line from master. I also removed another unused string from master.
        Hide
        Sam Hemelryk added a comment -

        Spot on!

        Show
        Sam Hemelryk added a comment - Spot on!
        Hide
        Dan Poltawski added a comment -

        Thanks Fred, integrated now!

        Show
        Dan Poltawski added a comment - Thanks Fred, integrated now!
        Hide
        Rajesh Taneja added a comment -

        Looks Good

        Thanks for fixing this Fred.

        Show
        Rajesh Taneja added a comment - Looks Good Thanks for fixing this Fred.
        Hide
        Dan Poltawski added a comment -

        Congratulations!

        Your work has made into the latest Moodle release!

        You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

        Show
        Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: