Moodle

same ID used on multiple buttons

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.1
  • Fix Version/s: 2.1.5, 2.2.2
  • Component/s: Accessibility
  • Labels:

Description

The buttons on the forgot password page have identical IDs. Each button simply needs to have a unique ID.

Issue Links

has a non-specific relationship to

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30892 buttons have unnecessary labels on forgot password page

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ankit Agarwal added a comment - - edited

Hi Glenn,
Can you review this please?
Thanks

Show
Ankit Agarwal added a comment - - edited Hi Glenn, Can you review this please? Thanks
Hide
Permalink
Glenn Ansley added a comment -

Looks good. I don't have ability to submit for integration though. Just a heads up.

Show
Glenn Ansley added a comment - Looks good. I don't have ability to submit for integration though. Just a heads up.
Hide
Permalink
Ankit Agarwal added a comment -

Thanks Glenn for the review
Submitting for integration.
Thanks

Show
Ankit Agarwal added a comment - Thanks Glenn for the review Submitting for integration. Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Ankit Agarwal added a comment -

rebased!

Show
Ankit Agarwal added a comment - rebased!
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Ankit this has been integrated now

Show
Sam Hemelryk added a comment - Thanks Ankit this has been integrated now
Hide
Permalink
Rossiani Wijaya added a comment -

This looks good.

Test passed.

Show
Rossiani Wijaya added a comment - This looks good. Test passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

icao_reverse('arreis olik rebemevon afla letoh ognat');

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: