Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.1
-
Component/s: Accessibility
-
Labels:
-
Testing Instructions:
- Goto login page and click on "Forgot password"
- Make sure both submit buttons have separate "id" atrributes
- Make sure the form works for a valid username and email id as expected
-
Difficulty:Easy
-
Affected Branches:MOODLE_21_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-30893-master -
Pull Master Diff URL:
Description
The buttons on the forgot password page have identical IDs. Each button simply needs to have a unique ID.
Gliffy Diagrams
Issue Links
- has a non-specific relationship to
-
MDL-30892
buttons have unnecessary labels on forgot password page
-
- Closed
-
Activity
Looks good. I don't have ability to submit for integration though. Just a heads up.
Thanks Glenn for the review
Submitting for integration.
Thanks
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
rebased!
Thanks Ankit this has been integrated now
This looks good.
Test passed.
Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).
icao_reverse('arreis olik rebemevon afla letoh ognat');
|
Closing, ciao
Hi Glenn,
Can you review this please?
Thanks