Details

    • Testing Instructions:
      Hide
      1. Upgrade moodle (if you are fetching latest integration.git you probably have already done it)
      2. Check the user table of the DB, there SHOULD NOT be a screenreader field
      3. Login as an admin
      4. Create or go to a course with course completion enabled
      5. Add some activities and users
      6. Go to Navigation -> Courses -> YOURCOURSENAME -> Reports -> Activity completion
      7. You SHOULD see the activity names in vertical (this is not part of this test, it is to be sure that you are a modern guy and you are using a modern browser, otherwise try another browser or if you are using IE use version 9)
      8. Inspect the activity HTML elements, the <a> tag to the activity SHOULD have a title attribute with the activity instance name; if you are using a screen reader it SHOULD name the activity instance name
      9. Create a chat activity
      10. View the chat activity, you SHOULD see two links, one with "Use more accessible interface" text
      11. Expand Navigation -> Courses -> YOURCOURSENAME -> YOURSECTIONAME -> YOURCHATACTIVITYNAME, you SHOULD see two links, one with "Use more accessible interface" text
      12. Go to admin tree -> Grades -> Report settings -> Grader report and enable "grade_report_fixedstudents"
      13. With editing turned off, go to the gradebook of a course with activities and users and select "Grader report" from the dropdown menu if it's not already selected
      14. Go over any of the grade items cells, you SHOULD see a overlay with the name of the student and the name of the activity
      15. Inspect the HTML code and find the overlay element (try with a graderreportoverlay search) it SHOULD have a tooltip role and a aria-describedby attribute
      16. Go to your profile, you SHOULD NOT see any screen reader - related setting
      17. Try a new 2.4 dev. install, it SHOULD finish as expected
      18. Check the user table of the DB, a mdl_user->screenreader field SHOULD NOT exists
      Show
      Upgrade moodle (if you are fetching latest integration.git you probably have already done it) Check the user table of the DB, there SHOULD NOT be a screenreader field Login as an admin Create or go to a course with course completion enabled Add some activities and users Go to Navigation -> Courses -> YOURCOURSENAME -> Reports -> Activity completion You SHOULD see the activity names in vertical (this is not part of this test, it is to be sure that you are a modern guy and you are using a modern browser, otherwise try another browser or if you are using IE use version 9) Inspect the activity HTML elements, the <a> tag to the activity SHOULD have a title attribute with the activity instance name; if you are using a screen reader it SHOULD name the activity instance name Create a chat activity View the chat activity, you SHOULD see two links, one with "Use more accessible interface" text Expand Navigation -> Courses -> YOURCOURSENAME -> YOURSECTIONAME -> YOURCHATACTIVITYNAME, you SHOULD see two links, one with "Use more accessible interface" text Go to admin tree -> Grades -> Report settings -> Grader report and enable "grade_report_fixedstudents" With editing turned off, go to the gradebook of a course with activities and users and select "Grader report" from the dropdown menu if it's not already selected Go over any of the grade items cells, you SHOULD see a overlay with the name of the student and the name of the activity Inspect the HTML code and find the overlay element (try with a graderreportoverlay search) it SHOULD have a tooltip role and a aria-describedby attribute Go to your profile, you SHOULD NOT see any screen reader - related setting Try a new 2.4 dev. install, it SHOULD finish as expected Check the user table of the DB, a mdl_user->screenreader field SHOULD NOT exists
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30901_master
    • Rank:
      33909

      Description

      The "screen reader" profile setting has very little impact in the UI. From an examination of the source code it only appears to impact the Chat activity and a grade book column for student names. It should be dropped in favor of making all aspects of the UI accessible.

      If this setting is used, it should only be used in cases where a particular implementation cannot be made accessible to screen reader users and a different implementation needs to be rendered. This should only be done as a last resort since most aspects of Web pages and applications can be made accessible if implemented correctly.

        Issue Links

          Activity

          Hide
          Adrian Greeve added a comment -

          The patch for 30912 so far uses this user screen reader setting.

          Show
          Adrian Greeve added a comment - The patch for 30912 so far uses this user screen reader setting.
          Hide
          David Monllaó added a comment -

          Hi,

          This setting is currently being used in different parts of moodle:

          • To check if the user (and user agent) can handle rotated texts (https://github.com/moodle/moodle/blob/master/lib/moodlelib.php#L8814)
          • In the chat, show/hide the non-basic UI link (see also MDL-30917 to related work on this)
          • To check if the gradebook students columns should be fixed or not; they will be fixed if no screenreader is used AND CFG->grade_report_fixedstudents is enabled AND a "new" browser is being used, so in this case the setting is used but do not determine anything by itself

          I've attached a proposal removing the setting and, alternatively, adding attributes to ease the reading with screen readers:

          • Adding a title attribute to the link showing the rotated text
          • In case an modern browser the being used and $CFG->grade_report_fixedstudents is enabled, I've added a tooltip role and related attribute to the gradebook cells tooltip
          • The chat use of the "screenreader" setting can be removed without collateral issues

          Note for integrators: I've changed version.php and VERSION attr. from install.xml to get rid of mdl_user->screenreader

          Show
          David Monllaó added a comment - Hi, This setting is currently being used in different parts of moodle: To check if the user (and user agent) can handle rotated texts ( https://github.com/moodle/moodle/blob/master/lib/moodlelib.php#L8814 ) In the chat, show/hide the non-basic UI link (see also MDL-30917 to related work on this) To check if the gradebook students columns should be fixed or not; they will be fixed if no screenreader is used AND CFG->grade_report_fixedstudents is enabled AND a "new" browser is being used, so in this case the setting is used but do not determine anything by itself I've attached a proposal removing the setting and, alternatively, adding attributes to ease the reading with screen readers: Adding a title attribute to the link showing the rotated text In case an modern browser the being used and $CFG->grade_report_fixedstudents is enabled, I've added a tooltip role and related attribute to the gradebook cells tooltip The chat use of the "screenreader" setting can be removed without collateral issues Note for integrators: I've changed version.php and VERSION attr. from install.xml to get rid of mdl_user->screenreader
          Hide
          Jason Fowler added a comment -

          looks good to me David

          Show
          Jason Fowler added a comment - looks good to me David
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          David Monllaó added a comment -

          Rebased

          Show
          David Monllaó added a comment - Rebased
          Hide
          Sam Hemelryk added a comment -

          Thanks David, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks David, this has been integrated now
          Hide
          Jason Hardin added a comment -

          From Moodlerooms perspective the removal of this user setting will causes us to have to create a user preference that a user sets in each interface that we need to allow an alternative accessible interface. I don't think this solution provides a useable alternative.

          To me you are providing administrators with two options

          1. Allow fixed student columns in the grade book for sighted teachers but make it inaccessible to visually impaired
          2. Do not allow fixed student columns in the grade book and make it accessible

          Neither is an ideal solution for an administrator that has teachers who require the fixed student column to use the Moodle grade book and have visually impaired teachers who need the accessible gradebook.

          Grade books are the most complex part of any LMS. Static columns are required for any course with more than 10 assignments. There are other similar reporting interfaces that Moodle doesn't have that would require a static column too. Removing this setting requires a developer of such interfaces to create user preferences and clutter the database with feature specific screen reader settings.

          While I agree the setting may not be used well in Core Moodle there are other community plugins that could benefit from this feature and reduce the amount of data in the database over all.

          Show
          Jason Hardin added a comment - From Moodlerooms perspective the removal of this user setting will causes us to have to create a user preference that a user sets in each interface that we need to allow an alternative accessible interface. I don't think this solution provides a useable alternative. To me you are providing administrators with two options Allow fixed student columns in the grade book for sighted teachers but make it inaccessible to visually impaired Do not allow fixed student columns in the grade book and make it accessible Neither is an ideal solution for an administrator that has teachers who require the fixed student column to use the Moodle grade book and have visually impaired teachers who need the accessible gradebook. Grade books are the most complex part of any LMS. Static columns are required for any course with more than 10 assignments. There are other similar reporting interfaces that Moodle doesn't have that would require a static column too. Removing this setting requires a developer of such interfaces to create user preferences and clutter the database with feature specific screen reader settings. While I agree the setting may not be used well in Core Moodle there are other community plugins that could benefit from this feature and reduce the amount of data in the database over all.
          Hide
          Andrew Davis added a comment -

          Phew. Works as described. Passing.

          Show
          Andrew Davis added a comment - Phew. Works as described. Passing.
          Hide
          Dan Poltawski added a comment -

          Congratulations, you've done it!

          Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

          Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

          Show
          Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.
          Hide
          Greg Kraus added a comment -

          @Jason Hardin - one potential solution would be to have a hidden column of student names that are marked with <th> in the same table with the grades so the screen reader reads it correctly. That way you can still have the separate table just with the student names to create the fixed column effect. The way I've seen this done before is to overlay your fixed column as a separate table over top of the first column of the larger table.

          It might not be the most elegant solution, but then neither is having two separate tables to present one set of data.

          The solution you mentioned also works too, that you just make a user preference setting in the individual tool where the user can select to have a fixed column.

          While I don't like having a screen reader setting because I think it lets us go too easily down the path of creating two user interfaces when only one is needed, I also recognize sometimes two user interfaces are necessary. I guess the question is what is the best way to switch to the other UI. One other solution would be to put some text somewhere within the UI, either on screen or off screen, that says "screen reader view of gradebook" that then takes you to an alternative view where there is no fixed column. That flag could be set as a URL parameter.

          Show
          Greg Kraus added a comment - @Jason Hardin - one potential solution would be to have a hidden column of student names that are marked with <th> in the same table with the grades so the screen reader reads it correctly. That way you can still have the separate table just with the student names to create the fixed column effect. The way I've seen this done before is to overlay your fixed column as a separate table over top of the first column of the larger table. It might not be the most elegant solution, but then neither is having two separate tables to present one set of data. The solution you mentioned also works too, that you just make a user preference setting in the individual tool where the user can select to have a fixed column. While I don't like having a screen reader setting because I think it lets us go too easily down the path of creating two user interfaces when only one is needed, I also recognize sometimes two user interfaces are necessary. I guess the question is what is the best way to switch to the other UI. One other solution would be to put some text somewhere within the UI, either on screen or off screen, that says "screen reader view of gradebook" that then takes you to an alternative view where there is no fixed column. That flag could be set as a URL parameter.
          Hide
          Jason Hardin added a comment -

          @Greg Kraus - I will have our developers look into the option.

          I don't necessarily agree that a screen reader option lets us go easily down the 2 interfaces path. The cost of properly maintaining 2 interfaces is the reason we should not maintain 2 interfaces if 1 interface can be made accessible.

          Removing the screen reader option means that Moodle will need to call out inaccessible interfaces via user preferences or alternative links, mostly this will be the gradebook and maybe there all that is needed is 1 accessibile gradebook report.

          From what i have seen the current Moodle gradebook is to complex to be accessible is that changing in 2.4 since this feature is removed?

          Show
          Jason Hardin added a comment - @Greg Kraus - I will have our developers look into the option. I don't necessarily agree that a screen reader option lets us go easily down the 2 interfaces path. The cost of properly maintaining 2 interfaces is the reason we should not maintain 2 interfaces if 1 interface can be made accessible. Removing the screen reader option means that Moodle will need to call out inaccessible interfaces via user preferences or alternative links, mostly this will be the gradebook and maybe there all that is needed is 1 accessibile gradebook report. From what i have seen the current Moodle gradebook is to complex to be accessible is that changing in 2.4 since this feature is removed?
          Hide
          Mary Cooch added a comment -

          Removing docs_required label as this change is now reflected here http://docs.moodle.org/24/en/Update_profile

          Show
          Mary Cooch added a comment - Removing docs_required label as this change is now reflected here http://docs.moodle.org/24/en/Update_profile

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: