Details

    • Testing Instructions:
      Hide

      1. Purge your cache
      2. Go to your profile page (Navigation > Home > My profile > View profile)
      3. Make sure the left column of the profile table uses <th> tags and page looks fine
      4. Go to a course user profile (via the course participants list for example)
      5. Make sure the left column of the profile table uses <th> tags and page looks fine
      6. Repeat test on a few different themes

      Show
      1. Purge your cache 2. Go to your profile page (Navigation > Home > My profile > View profile) 3. Make sure the left column of the profile table uses <th> tags and page looks fine 4. Go to a course user profile (via the course participants list for example) 5. Make sure the left column of the profile table uses <th> tags and page looks fine 6. Repeat test on a few different themes
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30903-master
    • Rank:
      33911

      Description

      The View Profile page uses a table for layout, but the way it is used there should probably be headings for the left column.

        Activity

        Hide
        Frédéric Massart added a comment -

        I have added a CSS property to reproduce the initial design.

        Show
        Frédéric Massart added a comment - I have added a CSS property to reproduce the initial design.
        Hide
        Sam Hemelryk added a comment -

        Hi Fred,

        Looks like you missed the closing </td> for the tag you've converted to a th.
        Also I wonder whether it is best to give each th a class and style that rather than style every th within the userprofile div as that is going to be prone to problems if/when that page is editing if tables are altered.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Fred, Looks like you missed the closing </td> for the tag you've converted to a th. Also I wonder whether it is best to give each th a class and style that rather than style every th within the userprofile div as that is going to be prone to problems if/when that page is editing if tables are altered. Cheers Sam
        Hide
        Frédéric Massart added a comment -

        Submitting for a second review.

        Show
        Frédéric Massart added a comment - Submitting for a second review.
        Hide
        Sam Hemelryk added a comment -

        Thanks Fred, putting this up for integration immediately (sorry in the delay peer-reviewing)

        Show
        Sam Hemelryk added a comment - Thanks Fred, putting this up for integration immediately (sorry in the delay peer-reviewing)
        Hide
        Dan Poltawski added a comment -

        Thanks Fred integrated to master, 23, 22, 21.

        Note we won't be accepting 2.1 patches after this week.

        Show
        Dan Poltawski added a comment - Thanks Fred integrated to master, 23, 22, 21. Note we won't be accepting 2.1 patches after this week.
        Hide
        Jason Fowler added a comment -

        looks good to me Fred!

        Show
        Jason Fowler added a comment - looks good to me Fred!
        Hide
        Sam Hemelryk added a comment -

        Congratulations your code is upstream - gold star for you!

        This issue + 79 others made it in in time for the minor releases.
        Thank you everyone involved for your exuberant efforts.

        Show
        Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: