Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. navigate to course calendar (http:// {your_moodle_site}

        /calendar/view.php?course=

        {course_id}

        &view=month&cal_d=1&cal_m=3&cal_y=2012)

      3. Open firebug (or any web development tool) and inspect (click to hide) link.
      4. Make sure they are unique and of form
        <td><strong>Global events</strong> shown (<a href="foo">click to hide <span class="accesshide">global events</span></a>)</td>
      5. Click on links and inspect again.
      Show
      Log in as admin navigate to course calendar (http:// {your_moodle_site} /calendar/view.php?course= {course_id} &view=month&cal_d=1&cal_m=3&cal_y=2012) Open firebug (or any web development tool) and inspect (click to hide) link. Make sure they are unique and of form <td><strong>Global events</strong> shown (<a href="foo">click to hide <span class="accesshide">global events</span></a>)</td> Click on links and inspect again.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      wip-mdl-30904

      Description

      When viewing the calendar, the "click to hide" link text is repeated often and should be unique for each type of event to show or hide. This could be done by changing the visual text on the page to something like "click to hide global events." Alternatively, an image could be used (like the eye icon) and the alt text could be unique for each link.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Hello Greg,

            I checked calendar and hide icon, but couldn't find any "click to hide" link. Can you please confirm where should I look for this link.

            FYI: I can only see proper links "Global events are shown (click to hide)".

            Show
            rajeshtaneja Rajesh Taneja added a comment - Hello Greg, I checked calendar and hide icon, but couldn't find any "click to hide" link. Can you please confirm where should I look for this link. FYI: I can only see proper links "Global events are shown (click to hide)".
            Hide
            gdkraus Greg Kraus added a comment -

            Those are the links I'm referring to. One way a screen reader user will read a page is by getting a list of all of the links. In this case the user will hear "click to hide, click to hide, click to hide, click to hide". The user won't know the context of the link so won't be able to distinguish what each link does. Basically, each link needs to uniquely identify what it does. One possibility is to code it like this.

            <td><strong>Global events</strong> shown (<a href="foo">click to hide <span class="accesshide">global events</span></a>)</td>

            Show
            gdkraus Greg Kraus added a comment - Those are the links I'm referring to. One way a screen reader user will read a page is by getting a list of all of the links. In this case the user will hear "click to hide, click to hide, click to hide, click to hide". The user won't know the context of the link so won't be able to distinguish what each link does. Basically, each link needs to uniquely identify what it does. One possibility is to code it like this. <td><strong>Global events</strong> shown (<a href="foo">click to hide <span class="accesshide">global events</span></a>)</td>
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for the quick feedback Greg

            Can you please suggest if adding title to link can solve this issue?

            <td><strong>Global events</strong> shown (<a href="foo" title="Global events shown (click to hide)">click to hide <span class="accesshide">global events</span></a>)</td>
            or

            <td><a href="foo"><strong>Global events</strong> shown (click to hide <span class="accesshide">global events</span>)</a></td>

            is the only way?

            Unrelated question
            How does screen reader interpret alt and title attributes for image?
            <img title="moodle title" alt="Moodle image" src="http://moodle.org/moodle.png">

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for the quick feedback Greg Can you please suggest if adding title to link can solve this issue? <td><strong>Global events</strong> shown (<a href="foo" title="Global events shown (click to hide)">click to hide <span class="accesshide">global events</span></a>)</td> or <td><a href="foo"><strong>Global events</strong> shown (click to hide <span class="accesshide">global events</span>)</a></td> is the only way? Unrelated question How does screen reader interpret alt and title attributes for image? <img title="moodle title" alt="Moodle image" src="http://moodle.org/moodle.png">
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Hello Greg,

            Can you please provide some inputs for my previous query.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Hello Greg, Can you please provide some inputs for my previous query.
            Hide
            gdkraus Greg Kraus added a comment -

            In general, the title attribute is a very unreliable method to communicate additional information to users. Screen readers handle the title attribute in different ways. Here is a sample of the different ways screen readers handle the title attribute.

            http://tracker.moodle.org/browse/MDL-31976?focusedCommentId=149825&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-149825

            Browsers also handle the title attribute differently. They are nice for tooltips in desktop browsers, but they are pointless in a touch interface because the user cannot access them in any way.

            For the problem we are trying to solve here, the title attribute won't fully address it, so I would recommend something like the code sample I listed above.

            Show
            gdkraus Greg Kraus added a comment - In general, the title attribute is a very unreliable method to communicate additional information to users. Screen readers handle the title attribute in different ways. Here is a sample of the different ways screen readers handle the title attribute. http://tracker.moodle.org/browse/MDL-31976?focusedCommentId=149825&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-149825 Browsers also handle the title attribute differently. They are nice for tooltips in desktop browsers, but they are pointless in a touch interface because the user cannot access them in any way. For the problem we are trying to solve here, the title attribute won't fully address it, so I would recommend something like the code sample I listed above.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for the inputs Greg.
            Pushing it for peer-review.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for the inputs Greg. Pushing it for peer-review.
            Hide
            phalacee Jason Fowler added a comment -

            Looks good Raj

            Show
            phalacee Jason Fowler added a comment - Looks good Raj
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Branches re-based.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Branches re-based.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Just noting that when viewing the calendar there is the Events Key fake block that gets added to the display and serves the sole purpose of hiding/showing event types.
            It does pretty much the same thing, but takes a different approach in how it structures the HTML.
            Perhaps that should be part of this issue as well, and the accessibility of that considered too. I am a big fan of the use of the eye image as well, however I'd bet the use of a table there is horrible for usability.
            Perhaps its time to come up with a tableless solution to this that is created with accessibility and usability in mind.

            Food for thought is all.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Just noting that when viewing the calendar there is the Events Key fake block that gets added to the display and serves the sole purpose of hiding/showing event types. It does pretty much the same thing, but takes a different approach in how it structures the HTML. Perhaps that should be part of this issue as well, and the accessibility of that considered too. I am a big fan of the use of the eye image as well, however I'd bet the use of a table there is horrible for usability. Perhaps its time to come up with a tableless solution to this that is created with accessibility and usability in mind. Food for thought is all. Cheers Sam
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for pointing about the fake block Sam,
            I saw that and links created there are proper links. It might be a nice to have, consistent behaviour on block and page (having eye image). But saying so, it is UI change and probably a good contender for 2.3.

            Let me know and I will open another issue to fix this

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for pointing about the fake block Sam, I saw that and links created there are proper links. It might be a nice to have, consistent behaviour on block and page (having eye image). But saying so, it is UI change and probably a good contender for 2.3. Let me know and I will open another issue to fix this
            Hide
            poltawski Dan Poltawski added a comment -

            Hmm, I am going to integrate this as an incremental improvement.

            But I think I agree we should create an issue to sort out that block into tabless layout and get rid of the duplication between these two pieces - the screen reader is potentially faced with two of these.

            Show
            poltawski Dan Poltawski added a comment - Hmm, I am going to integrate this as an incremental improvement. But I think I agree we should create an issue to sort out that block into tabless layout and get rid of the duplication between these two pieces - the screen reader is potentially faced with two of these.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks, this has been integrated now.

            Show
            poltawski Dan Poltawski added a comment - Thanks, this has been integrated now.
            Hide
            poltawski Dan Poltawski added a comment -

            Raj - can you open an issue for the other block

            Show
            poltawski Dan Poltawski added a comment - Raj - can you open an issue for the other block
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Hello Dan,
            I have created MDL-32309 for this.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Hello Dan, I have created MDL-32309 for this.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This looks good.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This looks good. Test passed.
            Hide
            nebgor Aparup Banerjee added a comment -

            The code here has been spread to upstream moodle repositories and mirrors for anyone to use .

            Closing, have a good weekend!

            Show
            nebgor Aparup Banerjee added a comment - The code here has been spread to upstream moodle repositories and mirrors for anyone to use . Closing, have a good weekend!

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12