Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Accessibility
    • Labels:
    • Testing Instructions:
      Hide

      Testing level: Moderate (need small code hack)

      1. Create a new course, and turn editing on.
      2. In the top section (the one with the default 'News Forum'), create an online-text assignment called 'Test 1'.
      3. In the same section, create a forum called 'Test 2' and hide it.
      4. In any other section, create a forum called 'Test 3', and a hidden online-text assignment called 'Test 4'.
      6. Go to the 'Full report of recent activity' (link in recent activity block)
      7. Make sure that:

      • The page looks good
      • There is not empty <h2> tag in the first section containing Test 1 and Test 2
      • The name of the second section is displayed in an <h2> tag
      • Test 2 and Test 4 have the class 'dimmed'

      8. Hack the code of course/recent.php and look for the line

      if (!empty($activities)) {
      

      replace it with

      if (false && !empty($activities)) {
      

      9. Refresh the recent activity page, and make sure that 'No recent activity' appears centered on the page.
      10. Check step 7 and 9 with a few other themes.

      Show
      Testing level: Moderate (need small code hack) 1. Create a new course, and turn editing on. 2. In the top section (the one with the default 'News Forum'), create an online-text assignment called 'Test 1'. 3. In the same section, create a forum called 'Test 2' and hide it. 4. In any other section, create a forum called 'Test 3', and a hidden online-text assignment called 'Test 4'. 6. Go to the 'Full report of recent activity' (link in recent activity block) 7. Make sure that: The page looks good There is not empty <h2> tag in the first section containing Test 1 and Test 2 The name of the second section is displayed in an <h2> tag Test 2 and Test 4 have the class 'dimmed' 8. Hack the code of course/recent.php and look for the line if (!empty($activities)) { replace it with if ( false && !empty($activities)) { 9. Refresh the recent activity page, and make sure that 'No recent activity' appears centered on the page. 10. Check step 7 and 9 with a few other themes.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30905-master
    • Rank:
      33913

      Description

      There are empty heading tags on this page that have no content. They need to be removed.

        Activity

        Hide
        Frédéric Massart added a comment -

        Note to reviewer: while fixing the empty tag, I realised that a <center> tag was also used which is not XHTML compliant, and that the html_writer class could be used at some places. That explains the unrelated changes.

        Show
        Frédéric Massart added a comment - Note to reviewer: while fixing the empty tag, I realised that a <center> tag was also used which is not XHTML compliant, and that the html_writer class could be used at some places. That explains the unrelated changes.
        Hide
        Sam Hemelryk added a comment -

        Hi Fred,

        Changes look good and if you like you can put them up for integration now as they are a clear improvement.
        However the following changes could be made if you like:

        1. Generating the image (ln242) could be done with $OUTPUT->pix_icon instead of html_writer and pix_url.
        2. Generating the link (ln244) could be done with html_writer::link and should use a moodle_url object for the href.
        3. It would be great to give the centred heading (ln276) the 'mdl-align' css class to centre it rather than using an inline style.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Fred, Changes look good and if you like you can put them up for integration now as they are a clear improvement. However the following changes could be made if you like: Generating the image (ln242) could be done with $OUTPUT->pix_icon instead of html_writer and pix_url. Generating the link (ln244) could be done with html_writer::link and should use a moodle_url object for the href. It would be great to give the centred heading (ln276) the 'mdl-align' css class to centre it rather than using an inline style. Cheers Sam
        Hide
        Frédéric Massart added a comment -

        Here are the updated code Sam. I kept the class 'icon' for the image and added 'smallicon' normally set by pix_icon(). Keeping 'icon' slightly improved the look by vertically aligning the icon.

        Show
        Frédéric Massart added a comment - Here are the updated code Sam. I kept the class 'icon' for the image and added 'smallicon' normally set by pix_icon(). Keeping 'icon' slightly improved the look by vertically aligning the icon.
        Hide
        Sam Hemelryk added a comment -

        Thanks Fred, looks spot on and so I've put it up for integration now

        Show
        Sam Hemelryk added a comment - Thanks Fred, looks spot on and so I've put it up for integration now
        Hide
        Dan Poltawski added a comment -

        Thanks Fred,

        I've integrated this now. Just another thing FYI which might come in useful, you can use $OUTPUT->heading() to generate h3 tags (see lib/outputrenderers.php )

        Show
        Dan Poltawski added a comment - Thanks Fred, I've integrated this now. Just another thing FYI which might come in useful, you can use $OUTPUT->heading() to generate h3 tags (see lib/outputrenderers.php )
        Hide
        Rajesh Taneja added a comment -

        Looks Good.

        Thanks for fixing this Fred

        Show
        Rajesh Taneja added a comment - Looks Good. Thanks for fixing this Fred
        Hide
        Dan Poltawski added a comment -

        Congratulations!

        Your work has made into the latest Moodle release!

        You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

        Show
        Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: