Details

    • Testing Instructions:
      Hide

      You will need to have done some activity with your moodle site. Put some entries into such activities as forum posts, assignment submissions, quiz completion.
      1) Enter a course that you have done some activities.
      2) Install the recent activity block.
      3) Click on the link titled 'Full report of recent activity'.
      4) Change the 'Since' date to some time in the past to get a reasonable amount of results.
      5) Use firebug or some other program to inspect the html of the page.
      [TEST] The Course title should be <h1> and the heading under the breadcrumb navigation should be <h2> and so on going down in a logical order to <h4> for the different elements.

      Show
      You will need to have done some activity with your moodle site. Put some entries into such activities as forum posts, assignment submissions, quiz completion. 1) Enter a course that you have done some activities. 2) Install the recent activity block. 3) Click on the link titled 'Full report of recent activity'. 4) Change the 'Since' date to some time in the past to get a reasonable amount of results. 5) Use firebug or some other program to inspect the html of the page. [TEST] The Course title should be <h1> and the heading under the breadcrumb navigation should be <h2> and so on going down in a logical order to <h4> for the different elements.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-30906-master
    • Rank:
      33914

      Description

      The headings are out of order on the recent activity page and need to be put in sequential order instead of skipping over heading levels.

        Activity

        Hide
        Adrian Greeve added a comment -

        I'm not exactly sure of what you mean when you say that the headings are out of order on the recent activity page. Could you possibly elaborate a bit further and maybe include a screenshot of what you mean?

        Thanks.

        Show
        Adrian Greeve added a comment - I'm not exactly sure of what you mean when you say that the headings are out of order on the recent activity page. Could you possibly elaborate a bit further and maybe include a screenshot of what you mean? Thanks.
        Hide
        Adrian Greeve added a comment -

        I hope I'm right. Do you mean the <h1><h2> headings on this page? I noticed that the page goes from <h2> to <h4> and that the main title of the course had a <h3> heading. I've created a patch that changes those around so that they should be in the correct order.

        Show
        Adrian Greeve added a comment - I hope I'm right. Do you mean the <h1><h2> headings on this page? I noticed that the page goes from <h2> to <h4> and that the main title of the course had a <h3> heading. I've created a patch that changes those around so that they should be in the correct order.
        Hide
        Rossiani Wijaya added a comment -

        Hi Adrian,

        Could you also change the heading level on line 272 for nonrecentactivity string? It opens with <h4> but close with <h2> tags. I think it should also use level 3 heading.

        Other than that, the patch looks good.

        Show
        Rossiani Wijaya added a comment - Hi Adrian, Could you also change the heading level on line 272 for nonrecentactivity string? It opens with <h4> but close with <h2> tags. I think it should also use level 3 heading. Other than that, the patch looks good.
        Hide
        Adrian Greeve added a comment -

        Thanks Rossie for the peer review. I made the change that you mentioned. Thanks for picking that up.

        Show
        Adrian Greeve added a comment - Thanks Rossie for the peer review. I made the change that you mentioned. Thanks for picking that up.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Added missing pull from repo field.

        Show
        Sam Hemelryk added a comment - Added missing pull from repo field.
        Hide
        Sam Hemelryk added a comment -

        Thanks Adrian this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Adrian this has been integrated now
        Hide
        Petr Škoda added a comment -

        tested, thanks

        Show
        Petr Škoda added a comment - tested, thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli
        Hide
        Teresa Gibbison added a comment -

        Here's a link for 2.0 I used this tracker item as a cherry-pick example using github for the first time properly!
        https://github.com/gibbisons/moodle/compare/MOODLE_20_STABLE...wip-MDL-30906-MOODLE_20_STABLE

        Cheers
        Teresa

        Show
        Teresa Gibbison added a comment - Here's a link for 2.0 I used this tracker item as a cherry-pick example using github for the first time properly! https://github.com/gibbisons/moodle/compare/MOODLE_20_STABLE...wip-MDL-30906-MOODLE_20_STABLE Cheers Teresa

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: