Details

    • Testing Instructions:
      Hide

      1. Create lesson activity in a course
      2. add content page
      3. as admin, pre-view content page and view source for the content page title and make sure it uses <h3> tag.
      4. as student, attempt the lesson and check the content page title is using <h3> tag.

      Show
      1. Create lesson activity in a course 2. add content page 3. as admin, pre-view content page and view source for the content page title and make sure it uses <h3> tag. 4. as student, attempt the lesson and check the content page title is using <h3> tag.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:

      Description

      The title of the individual content page should be an h3, so it is less than the lesson title which is an h2.

        Gliffy Diagrams

          Activity

          Hide
          rwijaya Rossiani Wijaya added a comment -

          Hi Greg,

          Could you provide the site url or page name for this?

          Show
          rwijaya Rossiani Wijaya added a comment - Hi Greg, Could you provide the site url or page name for this?
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Nevermind, I found the issue.

          Show
          rwijaya Rossiani Wijaya added a comment - Nevermind, I found the issue.
          Hide
          andyjdavis Andrew Davis added a comment -

          Hi. Consider adding a comment for these to explain to people in the future why there is a hard coded number 3 and why it is 3 (and not 2 or 4). Either that or use a constant. Up to you whether you want to do either of those things or just put it in as is.

          Show
          andyjdavis Andrew Davis added a comment - Hi. Consider adding a comment for these to explain to people in the future why there is a hard coded number 3 and why it is 3 (and not 2 or 4). Either that or use a constant. Up to you whether you want to do either of those things or just put it in as is.
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Hi Andrew,

          Thank you for reviewing.

          I added comment to the code and updated the patch.

          Submitting this for integration review.

          Show
          rwijaya Rossiani Wijaya added a comment - Hi Andrew, Thank you for reviewing. I added comment to the code and updated the patch. Submitting this for integration review.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Rosie, this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Rosie, this has been integrated now.
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          This is working as described!
          Passing
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - This is working as described! Passing Thanks
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

          Closing as fixed, heading to zzzZZZzzz, niao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12