Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: None
    • Component/s: Accessibility
    • Labels:
      None
    • Affected Branches:
      MOODLE_21_STABLE

      Description

      This is a general accessibility issue and specific instances should be noted.

      There are CSS rules that make text bolder. When appropriate, text should be coded with the strong tag instead of simply made bolder with CSS. Just make sure the rule is being applied appropriately.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            It would be good to have at least one specific case, rather than a general rule.

            Show
            salvetore Michael de Raadt added a comment - It would be good to have at least one specific case, rather than a general rule.
            Hide
            gdkraus Greg Kraus added a comment -

            I didn't notice any specific instances of this, but there were some CSS rules that made text bolder. That is fine, unless the reason you are making the text bolder is for emphasis. For instance, it's perfectly fine to use CSS to make text bolder for an h1, h2, etc., but it's not OK to use a CSS rule like .important-info

            {font-weight:bold;}

            to mark some text as bold simply because it's important. The reason the second example is not alright is because the screen reader user has no semantic information about the text being important. The accessible way to do it is to use the <strong> or <em> tags.

            This is akin to issue http://tracker.moodle.org/browse/MDL-30898, where there weren't any instances found, but the possibility of misuse was there because of existing CSS rules. I included this bug in this meta issue simply for completeness because it was part of the original report.

            Show
            gdkraus Greg Kraus added a comment - I didn't notice any specific instances of this, but there were some CSS rules that made text bolder. That is fine, unless the reason you are making the text bolder is for emphasis. For instance, it's perfectly fine to use CSS to make text bolder for an h1, h2, etc., but it's not OK to use a CSS rule like .important-info {font-weight:bold;} to mark some text as bold simply because it's important. The reason the second example is not alright is because the screen reader user has no semantic information about the text being important. The accessible way to do it is to use the <strong> or <em> tags. This is akin to issue http://tracker.moodle.org/browse/MDL-30898 , where there weren't any instances found, but the possibility of misuse was there because of existing CSS rules. I included this bug in this meta issue simply for completeness because it was part of the original report.
            Hide
            salvetore Michael de Raadt added a comment -

            I've created a section on the Dev Accessibility page with the point you have described.

            http://docs.moodle.org/dev/index.php?title=Accessibility&action=submit#Common_accessibility_coding_errors

            Please feel free to modify this and add general advise for developers.

            I'm going to close this issue as this is probably the best solution if we don't have specific cases.

            Show
            salvetore Michael de Raadt added a comment - I've created a section on the Dev Accessibility page with the point you have described. http://docs.moodle.org/dev/index.php?title=Accessibility&action=submit#Common_accessibility_coding_errors Please feel free to modify this and add general advise for developers. I'm going to close this issue as this is probably the best solution if we don't have specific cases.
            Hide
            gdkraus Greg Kraus added a comment -

            When I go to that link I can't see the pertinent text. That solution sounds good though.

            Show
            gdkraus Greg Kraus added a comment - When I go to that link I can't see the pertinent text. That solution sounds good though.
            Show
            salvetore Michael de Raadt added a comment - Doh! Let's try that again... http://docs.moodle.org/dev/Accessibility#Common_accessibility_coding_errors

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: