Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30924

Typo in the PSpellShell.php file - needs merge from upstream

    Details

    • Testing Instructions:
      Hide

      1/ install aspell
      2/ tell moodle where it is
      3/ configure tinymce to use it
      4/ try some simple english spell check (do not bother testing non-asci langs because it does not seem to work much)

      Show
      1/ install aspell 2/ tell moodle where it is 3/ configure tinymce to use it 4/ try some simple english spell check (do not bother testing non-asci langs because it does not seem to work much)
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w52_MDL-30924_m23_pspell

      Description

      As reported by Tomáš Nosek at moodle.cz, the shell engine for the spellchecker contains a typo causing the spellchecker does not work. I was looking for the upstream fix and found it - https://github.com/tinymce/tinymce_spellchecker_php/commit/1a147c5c771892ded5f7d615b2e5fd8f1d9328ed

      We should backport this into our TinyMCE build - see lib/editor/tinymce/readme_moodle.txt for more info

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            mudrd8mz David Mudrák added a comment -

            Petr, would you please look at this? I know you had a working environment for this plugin building. Thanks in advance.

            Show
            mudrd8mz David Mudrák added a comment - Petr, would you please look at this? I know you had a working environment for this plugin building. Thanks in advance.
            Hide
            skodak Petr Skoda added a comment -
            Show
            skodak Petr Skoda added a comment - I have updated our customised branch - https://github.com/moodle/custom-tinymce_spellchecker_php/tree/MOODLE_22_2.0.6a
            Hide
            skodak Petr Skoda added a comment -

            thanks for the report!

            Show
            skodak Petr Skoda added a comment - thanks for the report!
            Hide
            skodak Petr Skoda added a comment -

            to integrators: please cherry pick to 2.1.x and 2.2.x, please note we did not need to do a full build of tinymce because only php file is affected (which means no JS caching trouble)

            Show
            skodak Petr Skoda added a comment - to integrators: please cherry pick to 2.1.x and 2.2.x, please note we did not need to do a full build of tinymce because only php file is affected (which means no JS caching trouble)
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Petr,

            I've just been looking to this now. It doesn't cherry-pick cleanly to 2.1.
            A quick check and it looks like this is not needed in 2.1, could you please confirm that?

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Petr, I've just been looking to this now. It doesn't cherry-pick cleanly to 2.1. A quick check and it looks like this is not needed in 2.1, could you please confirm that? Cheers Sam
            Hide
            skodak Petr Skoda added a comment -

            oops, sorry it is not necessary in 2.1.x

            Show
            skodak Petr Skoda added a comment - oops, sorry it is not necessary in 2.1.x
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Petr - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Petr - this has been integrated now
            Hide
            mudrd8mz David Mudrák added a comment -

            Hi Sam. I can confirm the fix is not needed for the current MOODLE_21_STABLE. The spellchecker on 2.1 branch is based on the older upstream version

            https://github.com/tinymce/tinymce_spellchecker_php/commit/d237b5fc9c3f2dfeaf876ee7bdbd165e98fb5de5#classes/PSpellShell.php

            while this bug was introduced as a regression of the more recent upstream commit:

            https://github.com/tinymce/tinymce_spellchecker_php/commit/f1ed442b9f313d7c424595f85b5a98624c0cb948#classes/PSpellShell.php

            Show
            mudrd8mz David Mudrák added a comment - Hi Sam. I can confirm the fix is not needed for the current MOODLE_21_STABLE. The spellchecker on 2.1 branch is based on the older upstream version https://github.com/tinymce/tinymce_spellchecker_php/commit/d237b5fc9c3f2dfeaf876ee7bdbd165e98fb5de5#classes/PSpellShell.php while this bug was introduced as a regression of the more recent upstream commit: https://github.com/tinymce/tinymce_spellchecker_php/commit/f1ed442b9f313d7c424595f85b5a98624c0cb948#classes/PSpellShell.php
            Hide
            gerry Gerard Caulfield added a comment -

            Problem during testing during step 3

            I installed aspell, set the path to it, however I could not find where to set it at step 3 "configure tinymce to use it". The "Spell Engine" options included PSpell PSpellShell and Goodle Spell, but no aspell.

            Show
            gerry Gerard Caulfield added a comment - Problem during testing during step 3 I installed aspell, set the path to it, however I could not find where to set it at step 3 "configure tinymce to use it". The "Spell Engine" options included PSpell PSpellShell and Goodle Spell, but no aspell.
            Hide
            mudrd8mz David Mudrák added a comment -

            Gerard, the PSpellShell is the engine that runs the shell command "aspell"

            Show
            mudrd8mz David Mudrák added a comment - Gerard, the PSpellShell is the engine that runs the shell command "aspell"
            Hide
            gerry Gerard Caulfield added a comment -

            Thanks David

            Show
            gerry Gerard Caulfield added a comment - Thanks David
            Hide
            skodak Petr Skoda added a comment -

            process restarted, thanks

            Show
            skodak Petr Skoda added a comment - process restarted, thanks
            Hide
            gerry Gerard Caulfield added a comment -

            Passed

            Show
            gerry Gerard Caulfield added a comment - Passed
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/12