Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30944

fix bugs and improve enrol_cohort

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      1/ Setup cohort sync in some courses
      2/ test all combinations of cohort assignments/unassignments/deleting
      3/ concentrate on event sync first
      4/ edit code to disable event sync and repeat with CLI sync script

      Show
      1/ Setup cohort sync in some courses 2/ test all combinations of cohort assignments/unassignments/deleting 3/ concentrate on event sync first 4/ edit code to disable event sync and repeat with CLI sync script
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w02_MDL-30944_m23_cohortenrol

      Description

      We need:

      • optional suspending of enrolments instead of full unenrol
      • increase cron period
      • improve perf
      • remove roles when instance disabled
      • CLI diagnostic sync script
      • uninstaller support
      • allow no role sync

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            To integrators: please consider cherry picking to 2.2.x

            Show
            skodak Petr Skoda added a comment - To integrators: please consider cherry picking to 2.2.x
            Hide
            skodak Petr Skoda added a comment -

            I have added manual unenrol option for suspended users...

            Show
            skodak Petr Skoda added a comment - I have added manual unenrol option for suspended users...
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

            This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

            This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

            Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Petr,

            Changes looked good to me and this has been integrated now.
            Just noting that during my playing with this I noted that cohort restore isn't working yet (still giving a this will be done in Moodle 2.0 notice that we should probably update).
            I'm going to see if I can find an issue for that and bump it now.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Petr, Changes looked good to me and this has been integrated now. Just noting that during my playing with this I noted that cohort restore isn't working yet (still giving a this will be done in Moodle 2.0 notice that we should probably update). I'm going to see if I can find an issue for that and bump it now. Cheers Sam
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: passed . That seemed to work well for me.

            I was able to get control event sync on the cohort side then trigger the sync via CLI:

            D:\xampp\htdocs\moodle_testing\enrol\cohort\cli>php sync.php -v
            Starting user enrolment synchronisation...
              enrolling: 9 ==> 2 via cohort 1
              assigning role: 9 ==> 2 as student
            ...user enrolment synchronisation finished.

            Show
            salvetore Michael de Raadt added a comment - Test result: passed . That seemed to work well for me. I was able to get control event sync on the cohort side then trigger the sync via CLI: D:\xampp\htdocs\moodle_testing\enrol\cohort\cli>php sync.php -v Starting user enrolment synchronisation... enrolling: 9 ==> 2 via cohort 1 assigning role: 9 ==> 2 as student ...user enrolment synchronisation finished.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This virus has been spread upstream, everybody will be infected soon. Congrats, you did it!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This virus has been spread upstream, everybody will be infected soon. Congrats, you did it! Closing, ciao
            Hide
            tsala Helen Foster added a comment -

            Hi, any reason why this issue wasn't backported to 2.2.x or could be done now, as requested in http://moodle.org/mod/forum/discuss.php?d=208915?

            Show
            tsala Helen Foster added a comment - Hi, any reason why this issue wasn't backported to 2.2.x or could be done now, as requested in http://moodle.org/mod/forum/discuss.php?d=208915?
            Hide
            skodak Petr Skoda added a comment -

            Hi, this change included new features and backwards incompatible changes, also there was some unrelated cleanup in 2.3 that complicated any backporting.

            Show
            skodak Petr Skoda added a comment - Hi, this change included new features and backwards incompatible changes, also there was some unrelated cleanup in 2.3 that complicated any backporting.
            Hide
            tsala Helen Foster added a comment -

            Thanks for the info Petr.

            Show
            tsala Helen Foster added a comment - Thanks for the info Petr.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12