Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Messages
    • Labels:
    • Rank:
      37344

      Description

      There are two ways to suspend user accounts:
      1/ user.auth==nologin
      2/ user.suspended==1

      All messaging plugins need to be fixed, at the same time we could prevent messaging to deleted users too.

      OH! Please note that word "messaging" here does not mean the direct sending of messages between users in moodle, it is fine to send messages to users this way, they just do not get notification via email/jabber/etc.

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          The only potential problem here is performance - the messaging API could be refetching incomplete user records, but I suppose we ignored this till now and it should be probably adressed in 2.3 together with int parameters to message_send()

          To integrators: please cherry pick to 2.1.x and 2.2.x

          Show
          Petr Škoda added a comment - The only potential problem here is performance - the messaging API could be refetching incomplete user records, but I suppose we ignored this till now and it should be probably adressed in 2.3 together with int parameters to message_send() To integrators: please cherry pick to 2.1.x and 2.2.x
          Hide
          Petr Škoda added a comment -

          I have added one more commit preventing generation of new passwords in cron for suspended accounts - because they would can not get the email

          Show
          Petr Škoda added a comment - I have added one more commit preventing generation of new passwords in cron for suspended accounts - because they would can not get the email
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Do we really need to fetch the whole user record? At least reducing it to some sort of MESSAGING_REQUIRED_FIELDS or any other collection of fields would be better.

          Anyway, surely something to improve in 2.3... so integrating... ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Do we really need to fetch the whole user record? At least reducing it to some sort of MESSAGING_REQUIRED_FIELDS or any other collection of fields would be better. Anyway, surely something to improve in 2.3... so integrating... ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (21, 22 and master), thanks!

          Note for 21 I've made a new commit because the whole cronlib order was revamped for 22 and yours did not apply clean.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 and master), thanks! Note for 21 I've made a new commit because the whole cronlib order was revamped for 22 and yours did not apply clean.
          Hide
          Petr Škoda added a comment -

          grrr, sorry and thanks, my memory is getting really bad

          Show
          Petr Škoda added a comment - grrr, sorry and thanks, my memory is getting really bad
          Hide
          Jason Fowler added a comment -

          Took me a while to realize this was referring to the emails that go with the messages, and not the messages themselves ... but once I knew what I was doing the testing passed nicely

          Show
          Jason Fowler added a comment - Took me a while to realize this was referring to the emails that go with the messages, and not the messages themselves ... but once I knew what I was doing the testing passed nicely
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao
          Hide
          Helen Foster added a comment -

          Any chance we can get rid of the no login auth method now we have the 'Suspended account' setting?

          Show
          Helen Foster added a comment - Any chance we can get rid of the no login auth method now we have the 'Suspended account' setting?

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: