Also affects 2.1.x.

Looks like this has been caused by MDL-26461

Yep, in the example moodle.org forum post the average displayed on posts is correct, but the data displayed n the ratings page is being 'rounded down by 1'.

So it actually has 2 coolest thing ever ratings and 2 very cool ratings. Not quite sure why this was reduced in the attached bug.

Waiting for some info from people in MDL-26461 as to why this was introduced, otherwise reverting that change should fix this issue..

Working through this now. It all seems to be working correctly for numeric scales. Testing custom scales now.

Ok, I see the problem. This is the array for a numeric scale with a maximum rating of 5.

array(6) { [5]=> string(5) "5 / 5" [4]=> string(5) "4 / 5" [3]=> string(5) "3 / 5" [2]=> string(5) "2 / 5" [1]=> string(5) "1 / 5" [0]=> string(5) "0 / 5" }

Note that for a max grade of 5 there are 6 items, 0-6. Also, the indexes used are 0-6.

This is the array for a custom scale containing 4 elements.

array(4) { [4]=> string(6) "Ooooh!" [3]=> string(8) "Not Cool" [2]=> string(4) "Cool" [1]=> string(9) "Very Cool" } 

For four elements there four items and the indexes are 1-4.

The following is the code at fault

$maxrating = count($scalemenu) - 1;

To make it work I believe we want to take 1 off for numeric scales but not for custom scales. Implementing and testing this now.

Thanks Andrew

Added a possible solution and expanded the testing instructions a little.

Makes sense to me

Added branches. Up for integration.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Thanks Andrew, changes look spot on and this has been integrated now

Test result: Success.

Tested in 2.1, 2.2 and master.

Also tested this with student ratings.

Bonza mate!

Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby.

Hooroo