Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30957

A misleading submitted date shows up on the student view for assignment before the submission takes place

    Details

    • Testing Instructions:
      Hide
      1. Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
      2. The following test need to be run on 20, 21 and 22
        create an assignments of type "Upload a single file" and "Advanced uploading of files"
      3. Switch your role to student.
      4. Go to upload a file on both assignments.
      5. "Save changes" without choosing a file
      6. Check to make sure the date shown in the screenshot has not appeared.
      7. On both assignments go to upload a file again and this time actually upload a file.
      8. Now submit both assignments
      9. With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
      Show
      Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment. The following test need to be run on 20, 21 and 22 create an assignments of type "Upload a single file" and "Advanced uploading of files" Switch your role to student. Go to upload a file on both assignments. "Save changes" without choosing a file Check to make sure the date shown in the screenshot has not appeared. On both assignments go to upload a file again and this time actually upload a file. Now submit both assignments With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-30957_adding_assignment_completion_status_method_and_call

      Description

      MDL-29400 Fixes the displaying of a date and message which shows the file has been submitted. However another submitted date (although not labeled as such) still shows up on the student view in the top right header, as can be seen in the attached screenshot.

      Eloy spotted this on 29400, however after looking into the cause and issue, it is different from that in 29400. This issue is also less severe as the date isn't labeled as a submitted date. I am attaching a fix for this bug, however I am encountering notices under certain conditions and so I need to do some more testing to determine if these are related at all to the fix I'm providing. For these reasons I though it would be better to split this out into a separate issue.

        Gliffy Diagrams

          Issue Links

            Activity

            gerry Gerard Caulfield created issue -
            gerry Gerard Caulfield made changes -
            Field Original Value New Value
            Pull Master Diff URL https://github.com/gerrywastaken/moodle/compare/2117dcb5910944fbf8b991285be869ee31fd0ec3...6f92b4e2673b6e62b2203db18df45e6ac81b21ad
            Pull Master Branch wip_m_MDL-30957_adding_assignment_is_complete_method_and_call
            Pull from Repository git://github.com/gerrywastaken/moodle.git
            gerry Gerard Caulfield made changes -
            Link This issue discovered while testing MDL-29400 [ MDL-29400 ]
            gerry Gerard Caulfield made changes -
            Assignee moodle.com [ moodle.com ] Gerard Caulfield [ gerry ]
            gerry Gerard Caulfield made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            gerry Gerard Caulfield made changes -
            Link This issue has a non-specific relationship to MDL-30724 [ MDL-30724 ]
            nebgor Aparup Banerjee made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Peer reviewer nebgor
            nebgor Aparup Banerjee made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            gerry Gerard Caulfield made changes -
            Pull Master Branch wip_m_MDL-30957_adding_assignment_is_complete_method_and_call m_MDL-30957_adding_assignment_is_complete_method_and_call
            Pull 2.0 Diff URL https://github.com/gerrywastaken/moodle/compare/464ad0a47e6fcf93f56b3943a2e16d59b61f909c...b4092b0f75a7c9fe6ac8d567c0ac7fb494c1548a
            Pull 2.0 Branch 20_MDL-30957_adding_assignment_is_complete_method_and_call
            Pull 2.2 Diff URL https://github.com/gerrywastaken/moodle/compare/929c26ccf1cb483149d56c1961ed8ad655437463...782ede1d00cdfdb2c97978e17ec181c55b7342e6
            Pull 2.1 Branch 21_MDL-30957_adding_assignment_is_complete_method_and_call
            Pull 2.2 Branch 22_MDL-30957_adding_assignment_is_complete_method_and_call
            Pull 2.1 Diff URL https://github.com/gerrywastaken/moodle/compare/ddb7ae2f3cec5406a1c200839da10fdd8311c67a...6cc90e2c7d59868d14e9aed089e77cb2f2fc4df8
            gerry Gerard Caulfield made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Fix Version/s 2.2 [ 10656 ]
            Fix Version/s 2.1.3 [ 11251 ]
            Fix Version/s 2.0.6 [ 11250 ]
            Testing Instructions #Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
            #The following test need to be run on 20, 21 and 22
            create an assignments of type "Upload a single file" and "Advanced uploading of files"
            #Go to upload a file on both.
            #"Save changes" without choosing a file
            #On both assignments go to upload a file again and this time actually upload a file.
            #Now submit both assignments
            #With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
            gerry Gerard Caulfield made changes -
            Testing Instructions #Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
            #The following test need to be run on 20, 21 and 22
            create an assignments of type "Upload a single file" and "Advanced uploading of files"
            #Go to upload a file on both.
            #"Save changes" without choosing a file
            #On both assignments go to upload a file again and this time actually upload a file.
            #Now submit both assignments
            #With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
            # Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
            # The following test need to be run on 20, 21 and 22
            create an assignments of type "Upload a single file" and "Advanced uploading of files"
            # Go to upload a file on both.
            # "Save changes" without choosing a file
            # On both assignments go to upload a file again and this time actually upload a file.
            # Now submit both assignments
            # With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
            salvetore Michael de Raadt made changes -
            Labels triaged
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Reopened [ 4 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            gerry Gerard Caulfield made changes -
            Status Reopened [ 4 ] Development in progress [ 3 ]
            gerry Gerard Caulfield made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            salvetore Michael de Raadt made changes -
            Link This issue has been marked as being related by MDL-31579 [ MDL-31579 ]
            gerry Gerard Caulfield made changes -
            Link This issue will help resolve MDL-29400 [ MDL-29400 ]
            gerry Gerard Caulfield made changes -
            Link This issue discovered while testing MDL-29400 [ MDL-29400 ]
            nebgor Aparup Banerjee made changes -
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            nebgor Aparup Banerjee made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            gerry Gerard Caulfield made changes -
            Testing Instructions # Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
            # The following test need to be run on 20, 21 and 22
            create an assignments of type "Upload a single file" and "Advanced uploading of files"
            # Go to upload a file on both.
            # "Save changes" without choosing a file
            # On both assignments go to upload a file again and this time actually upload a file.
            # Now submit both assignments
            # With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
            # Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
            # The following test need to be run on 20, 21 and 22
            create an assignments of type "Upload a single file" and "Advanced uploading of files"
            # Switch your role to student.
            # Go to upload a file on both assignments.
            # "Save changes" without choosing a file
            # On both assignments go to upload a file again and this time actually upload a file.
            # Now submit both assignments
            # With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
            gerry Gerard Caulfield made changes -
            Testing Instructions # Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
            # The following test need to be run on 20, 21 and 22
            create an assignments of type "Upload a single file" and "Advanced uploading of files"
            # Switch your role to student.
            # Go to upload a file on both assignments.
            # "Save changes" without choosing a file
            # On both assignments go to upload a file again and this time actually upload a file.
            # Now submit both assignments
            # With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
            # Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
            # The following test need to be run on 20, 21 and 22
            create an assignments of type "Upload a single file" and "Advanced uploading of files"
            # Switch your role to student.
            # Go to upload a file on both assignments.
            # "Save changes" without choosing a file
            # Check to make sure the date shown in the screenshot has not appeared.
            # On both assignments go to upload a file again and this time actually upload a file.
            # Now submit both assignments
            # With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
            gerry Gerard Caulfield made changes -
            Pull Master Diff URL https://github.com/gerrywastaken/moodle/compare/master...m_MDL-30957_adding_assignment_is_complete_method_and_call https://github.com/gerrywastaken/moodle/compare/master...m_MDL-30957_adding_assignment_completion_status_method_and_call
            Pull Master Branch m_MDL-30957_adding_assignment_is_complete_method_and_call m_MDL-30957_adding_assignment_completion_status_method_and_call
            Pull 2.0 Diff URL https://github.com/gerrywastaken/moodle/compare/MOODLE_20_STABLE...20_MDL-30957_adding_assignment_is_complete_method_and_call https://github.com/gerrywastaken/moodle/compare/MOODLE_20_STABLE...20_MDL-30957_adding_assignment_completion_status_method_and_call
            Pull 2.0 Branch 20_MDL-30957_adding_assignment_is_complete_method_and_call 20_MDL-30957_adding_assignment_completion_status_method_and_call
            Pull 2.2 Diff URL https://github.com/gerrywastaken/moodle/compare/MOODLE_22_STABLE...22_MDL-30957_adding_assignment_is_complete_method_and_call https://github.com/gerrywastaken/moodle/compare/MOODLE_22_STABLE...22_MDL-30957_adding_assignment_completion_status_method_and_call
            Pull 2.1 Branch 21_MDL-30957_adding_assignment_is_complete_method_and_call 21_MDL-30957_adding_assignment_completion_status_method_and_call
            Pull 2.2 Branch 22_MDL-30957_adding_assignment_is_complete_method_and_call 22_MDL-30957_adding_assignment_completion_status_method_and_call
            Pull 2.1 Diff URL https://github.com/gerrywastaken/moodle/compare/MOODLE_21_STABLE...21_MDL-30957_adding_assignment_is_complete_method_and_call https://github.com/gerrywastaken/moodle/compare/MOODLE_21_STABLE...21_MDL-30957_adding_assignment_completion_status_method_and_call
            gerry Gerard Caulfield made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            salvetore Michael de Raadt made changes -
            Tester rajeshtaneja
            rajeshtaneja Rajesh Taneja made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            rajeshtaneja Rajesh Taneja made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            rajeshtaneja Rajesh Taneja made changes -
            Link This issue testing discovered MDL-31736 [ MDL-31736 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 23/Feb/12

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11