Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30957

A misleading submitted date shows up on the student view for assignment before the submission takes place

    Details

    • Testing Instructions:
      Hide
      1. Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment.
      2. The following test need to be run on 20, 21 and 22
        create an assignments of type "Upload a single file" and "Advanced uploading of files"
      3. Switch your role to student.
      4. Go to upload a file on both assignments.
      5. "Save changes" without choosing a file
      6. Check to make sure the date shown in the screenshot has not appeared.
      7. On both assignments go to upload a file again and this time actually upload a file.
      8. Now submit both assignments
      9. With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
      Show
      Look at the screenshot that is attached to this bug. While running through the following steps you should make sure that the date only appears after you have actually submitted the assignment. The following test need to be run on 20, 21 and 22 create an assignments of type "Upload a single file" and "Advanced uploading of files" Switch your role to student. Go to upload a file on both assignments. "Save changes" without choosing a file Check to make sure the date shown in the screenshot has not appeared. On both assignments go to upload a file again and this time actually upload a file. Now submit both assignments With the patch applied, the date shown in the screenshot should only have appeared after you submitted the assignment.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-30957_adding_assignment_completion_status_method_and_call

      Description

      MDL-29400 Fixes the displaying of a date and message which shows the file has been submitted. However another submitted date (although not labeled as such) still shows up on the student view in the top right header, as can be seen in the attached screenshot.

      Eloy spotted this on 29400, however after looking into the cause and issue, it is different from that in 29400. This issue is also less severe as the date isn't labeled as a submitted date. I am attaching a fix for this bug, however I am encountering notices under certain conditions and so I need to do some more testing to determine if these are related at all to the fix I'm providing. For these reasons I though it would be better to split this out into a separate issue.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    28/Nov/11