Moodle
  1. Moodle
  2. MDL-30958

disable Yahoo CDN when ssl used (including https login)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.2.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      1/ configure your test server to work with SSL
      2/ enable loginhttps and yahoo CDN for yui
      3/ verify normal pages are using yahoo servers
      4/ verify login page is using your server for yui
      5/ switch site to full sssl and verify it is using only your server no matter if Yahoo CDN selected

      Show
      1/ configure your test server to work with SSL 2/ enable loginhttps and yahoo CDN for yui 3/ verify normal pages are using yahoo servers 4/ verify login page is using your server for yui 5/ switch site to full sssl and verify it is using only your server no matter if Yahoo CDN selected
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w03_MDL-30958_m23_yuissl
    • Rank:
      37360

      Description

      It is not good idea to use nonssl JS and CSS on pages served via SSL...

        Activity

        Hide
        Petr Škoda added a comment -

        Notes:

        • the language pack change is valid for all Moodle versions, that is why I did not create a new string
        • I did not change the gallery part that is using $CFG->useexternalyui because it is overridden with "|| true"
        Show
        Petr Škoda added a comment - Notes: the language pack change is valid for all Moodle versions, that is why I did not create a new string I did not change the gallery part that is using $CFG->useexternalyui because it is overridden with "|| true"
        Hide
        Sam Hemelryk added a comment -

        Thanks Petr - this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Petr - this has been integrated now
        Hide
        Jason Fowler added a comment -

        Well, setting up SSL was fun, but once that was working, the test passed perfectly

        Show
        Jason Fowler added a comment - Well, setting up SSL was fun, but once that was working, the test passed perfectly
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now available in the git and cvs repositories.

        Consider the responsibility of your fingerprints engraved there for future generations!

        Thanks for the work, closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: