Moodle
  1. Moodle
  2. MDL-30961

get_course_contents web service's name value should be PARAM_RAW type not PARAM_TEXT

        Details

        • Rank:
          37363

          Description

          get_course_contents web service's name value should be PARAM_RAW type not PARAM_TEXT, because name could contain html tags.

          This issue affects moodle 2.2 onward

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Jérôme Mouneyrac added a comment -

            ping Dongsheng ?
            PS: I check the code it is ok to me, you can accept this as peer review

            Show
            Jérôme Mouneyrac added a comment - ping Dongsheng ? PS: I check the code it is ok to me, you can accept this as peer review
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Hi guys,

            I'm sending this back. Section name is PARAM_TEXT. The form for editing section and its handling confirms this.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi guys, I'm sending this back. Section name is PARAM_TEXT. The form for editing section and its handling confirms this. Cheers Sam
            Hide
            Permalink
            Jérôme Mouneyrac added a comment -

            I removed the section change from Dongsheng commit. Resending to integration.

            Show
            Jérôme Mouneyrac added a comment - I removed the section change from Dongsheng commit. Resending to integration.
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Thanks Jerome, this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Jerome, this has been integrated now.
            Hide
            Permalink
            Jason Fowler added a comment -

            All good Jerome

            Show
            Jason Fowler added a comment - All good Jerome
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: