Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30961

get_course_contents web service's name value should be PARAM_RAW type not PARAM_TEXT

          Details

            Description

            get_course_contents web service's name value should be PARAM_RAW type not PARAM_TEXT, because name could contain html tags.

            This issue affects moodle 2.2 onward

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  jerome Jérôme Mouneyrac added a comment -

                  ping Dongsheng ?
                  PS: I check the code it is ok to me, you can accept this as peer review

                  Show
                  jerome Jérôme Mouneyrac added a comment - ping Dongsheng ? PS: I check the code it is ok to me, you can accept this as peer review
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                  TIA and ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Hi guys,

                  I'm sending this back. Section name is PARAM_TEXT. The form for editing section and its handling confirms this.

                  Cheers
                  Sam

                  Show
                  samhemelryk Sam Hemelryk added a comment - Hi guys, I'm sending this back. Section name is PARAM_TEXT. The form for editing section and its handling confirms this. Cheers Sam
                  Hide
                  Permalink
                  jerome Jérôme Mouneyrac added a comment -

                  I removed the section change from Dongsheng commit. Resending to integration.

                  Show
                  jerome Jérôme Mouneyrac added a comment - I removed the section change from Dongsheng commit. Resending to integration.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Jerome, this has been integrated now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Jerome, this has been integrated now.
                  Hide
                  Permalink
                  phalacee Jason Fowler added a comment -

                  All good Jerome

                  Show
                  phalacee Jason Fowler added a comment - All good Jerome
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

                  Closing, ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        14/Jan/13