Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Rank:
      37408

      Description

      We need to test for compatibility issues with PHP 5.4RCx because it seems many ppl will upgrade their sites because of the hashing forms stuff vulnerability. It looks like we can not fully support PHP 5.2 and 5.4 at the same time so Moodle 2.0.x might get only show stopper fixes, no idea if we can fix 1.9.x issue.

      We should imo fix all warnings and notices in 2.3dev.

      Please create subtasks for individual issue, this is just a meta.

      NOTE: please include "PHP54" tag in commit message.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          It's a good time to be working on this.

          Show
          Michael de Raadt added a comment - It's a good time to be working on this.
          Hide
          Tomasz Muras added a comment -

          These are PHP 5.4 bugs related to the Moodle 1.9: I'm not sure if they're still relevant for M2.2:
          http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658865

          Show
          Tomasz Muras added a comment - These are PHP 5.4 bugs related to the Moodle 1.9: I'm not sure if they're still relevant for M2.2: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658865
          Hide
          Petr Škoda added a comment -

          Tomasz: no PHP54 support is planned for 1.9.x, sorry. please note it is still supposed to run on PHP4 which is another big problem for its maintenance

          Show
          Petr Škoda added a comment - Tomasz: no PHP54 support is planned for 1.9.x, sorry. please note it is still supposed to run on PHP4 which is another big problem for its maintenance
          Hide
          Petr Škoda added a comment -

          Everything seems to be working fine in master and latest 2.2.x should work as long as you set lower error level reporting.

          Show
          Petr Škoda added a comment - Everything seems to be working fine in master and latest 2.2.x should work as long as you set lower error level reporting.
          Hide
          Claus A. Us. added a comment -

          Our server administrator wants to switch PHP from version 5.3 to version 5.4. He pointed to some encoding problems due to changes of default char-set from ISO-8859-1 to UTF-8 within the following functions with version 5.4.0: htmlentities(), htmlspecialchars() and html_entity_decode().

          See: http://php.net/manual/en/function.htmlentities.php --> encoding -> first paragraph for more details.

          Moodle uses these functions very often without specifying the char-set:

          egrep -Riw "[^'"'"](htmlentities|htmlspecialchars|html_entity_decode)' /pathToMoodle/ | less
          
          Show
          Claus A. Us. added a comment - Our server administrator wants to switch PHP from version 5.3 to version 5.4. He pointed to some encoding problems due to changes of default char-set from ISO-8859-1 to UTF-8 within the following functions with version 5.4.0: htmlentities(), htmlspecialchars() and html_entity_decode(). See: http://php.net/manual/en/function.htmlentities.php --> encoding -> first paragraph for more details. Moodle uses these functions very often without specifying the char-set: egrep -Riw "[^'"'"](htmlentities|htmlspecialchars|html_entity_decode)' /pathToMoodle/ | less

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: