Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31013

'Export to Portfolio' Icon missing 'iconsmall' CSS class

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Portfolio
    • Labels:
    • Testing Instructions:
      Hide

      You will need to enable portfolios on your site

      • Go to [Site administration->Advanced features] and check Enable portfolios and save.
      • Go to [Site administration->Plugins->Portfolios->Manage portfolios] and make one of the plugins enabled and visible (Google Docs works )
      • Create a new glossary
      • Add a new item to the glossary
      • notice the size of the 'Export to portfolio' icon compared with others
      Show
      You will need to enable portfolios on your site Go to [Site administration->Advanced features] and check Enable portfolios and save. Go to [Site administration->Plugins->Portfolios->Manage portfolios] and make one of the plugins enabled and visible (Google Docs works ) Create a new glossary Add a new item to the glossary notice the size of the 'Export to portfolio' icon compared with others
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31013-master-1

      Description

      The icon for the 'Export to Portfolio' link on glossary items is missing the 'iconsmall' class

      On deeper inspection it appears that this would be difficult to add to just the Glossary, however it appears that the 'Export to Portfolio' icon is only used in:

      • mod/data/lib.php to allow users to export a single database entry - other icons have iconsmall
      • mod/forum/lib.php to allow users to export an attachment - no other icons so iconsmall works here

        Gliffy Diagrams

          Activity

          Hide
          abgreeve Adrian Greeve added a comment -

          Everything looks good and tested well. I just updated the testing instructions to let people know to enable portfolios.

          Thanks Andrew.

          Show
          abgreeve Adrian Greeve added a comment - Everything looks good and tested well. I just updated the testing instructions to let people know to enable portfolios. Thanks Andrew.
          Hide
          dobedobedoh Andrew Nicols added a comment -

          Just updated the affected versions.
          This patch cherry-picks cleanly to:

          • MOODLE_21_STABLE
          • MOODLE_22_STABLE
          • master
          Show
          dobedobedoh Andrew Nicols added a comment - Just updated the affected versions. This patch cherry-picks cleanly to: MOODLE_21_STABLE MOODLE_22_STABLE master
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Andrew, this has been integrated now and cherry-picked to 21, and 22.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now and cherry-picked to 21, and 22.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Tested during integration review. I also reviewed other uses of the portfolio export icon.

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Tested during integration review. I also reviewed other uses of the portfolio export icon. Cheers Sam
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

          Nah, joking, many thanks! Closing this a fixed, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12