Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: General
    • Labels:
    • Rank:
      37423

      Description

      This task is aimed to, progressively, take rid of as much incorrect whitespace as possible in codebase.

      So it will be split into successive "takes", each one applying changes to 1..n directories.

      It always will be applied to all currently supported branches.

      Some initial numbers (as of Jan 4th 2012):

      20_STABLE: 4334 occurrences (out of support since Dec 31th 2011).
      21_STABLE: 4269 occurrences.
      22_STABLE: 3259 occurrences.
      master: 3522 occurrences.

      These "takes" will be exceptionally applied (integrated) after the normal integration/testing cycle ends so will be available to developers once weeklies are sent upstream. Note they don't need testing as far as only whitespace changes are involved.

      Ciao

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sending to integration. This covers:

          • /admin
          • /auth
          • /backup

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Sending to integration. This covers: /admin /auth /backup Ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Eloy, integrated now

          Show
          Sam Hemelryk added a comment - Thanks Eloy, integrated now
          Hide
          Sam Hemelryk added a comment -

          No testing required - white space changes only

          Show
          Sam Hemelryk added a comment - No testing required - white space changes only
          Hide
          Eloy Lafuente (stronk7) added a comment -

          (thanks, Sam. Note, about our chat discussion of this conflicting with other issues, that i'll do these takes progressively and always after all issues in the week have been integrated). So chances of conflict are really low for everybody. Devs only will find them if they keep their local wip branches not rebased/merged for a long time and they fixed the same lines. Not big problem in any case, IMO).

          Show
          Eloy Lafuente (stronk7) added a comment - (thanks, Sam. Note, about our chat discussion of this conflicting with other issues, that i'll do these takes progressively and always after all issues in the week have been integrated). So chances of conflict are really low for everybody. Devs only will find them if they keep their local wip branches not rebased/merged for a long time and they fixed the same lines. Not big problem in any case, IMO).
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: