Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31018

Inconsistent horizontal alignment of choosepluginreport dropdown in Grader Report

    Details

    • Testing Instructions:
      Hide

      Testing the alignment of the Grader Report

      • as a teacher, open a course
      • Choose Settings -> Course Administration -> Grades
      • notice that the dropdown at the top of the page is on the left
      • use the dropdown to select another report
      • notice that the dropdown at the top of the page is on the left
      Show
      Testing the alignment of the Grader Report as a teacher, open a course Choose Settings -> Course Administration -> Grades notice that the dropdown at the top of the page is on the left use the dropdown to select another report notice that the dropdown at the top of the page is on the left
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31018-master-1

      Description

      The choosepluginreport dropdown which lets you select different reports (e.g. Grader Report, Outcomes Report, Overview Report, User Report), Import, Export, etc has an inconsistent horizontal alignment on the Grader Report compared with every other page

        Gliffy Diagrams

          Activity

          Hide
          dobedobedoh Andrew Nicols added a comment -

          I've removed the css which sets this to center. There don't seem to be any other forms on the page, and I believe that the CSS path should be fairly specific to that page.

          Show
          dobedobedoh Andrew Nicols added a comment - I've removed the css which sets this to center. There don't seem to be any other forms on the page, and I believe that the CSS path should be fairly specific to that page.
          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for working on this and (it looks like) a bunch of other issues over the last couple of weeks.

          I'm going to go through and triage these and see if we can get them peer-reviewers during the Scrum.

          Show
          salvetore Michael de Raadt added a comment - Thanks for working on this and (it looks like) a bunch of other issues over the last couple of weeks. I'm going to go through and triage these and see if we can get them peer-reviewers during the Scrum.
          Hide
          andyjdavis Andrew Davis added a comment - - edited

          The code change itself looks fine. Just update the testing instructions to be for someone testing the fix rather than trying to replicate the bug.

          If you haven't already check that this doesn't have any adverse effects if quick grading and/or quick feedback are turned on. Maybe theres no need but consider adding testing of some things that should not be affected by the change to the testing instructions.

          Show
          andyjdavis Andrew Davis added a comment - - edited The code change itself looks fine. Just update the testing instructions to be for someone testing the fix rather than trying to replicate the bug. If you haven't already check that this doesn't have any adverse effects if quick grading and/or quick feedback are turned on. Maybe theres no need but consider adding testing of some things that should not be affected by the change to the testing instructions.
          Hide
          dobedobedoh Andrew Nicols added a comment -

          I've updated the testing instructions.

          I've not found any forms which do appear in the path-grade-report-grade CSS path. The Quick Grade form is not affected from my testing.

          Show
          dobedobedoh Andrew Nicols added a comment - I've updated the testing instructions. I've not found any forms which do appear in the path-grade-report-grade CSS path. The Quick Grade form is not affected from my testing.
          Hide
          andyjdavis Andrew Davis added a comment -

          Looks good Are you able to put it up for integration or do you need me to do it? Also, should this go into any branches apart from master. It could probably go into 2.2 and 2.1 stable as well.

          Show
          andyjdavis Andrew Davis added a comment - Looks good Are you able to put it up for integration or do you need me to do it? Also, should this go into any branches apart from master. It could probably go into 2.2 and 2.1 stable as well.
          Hide
          dobedobedoh Andrew Nicols added a comment -

          Alas, I don't have the relevant rights to allow me to put it up for integration so if it's not up for integration by the time you get in that would be appreciated!

          This should cherry-pick cleanly to both:

          • MOODLE_21_STABLE; and
          • MOODLE_22_STABLE.
          Show
          dobedobedoh Andrew Nicols added a comment - Alas, I don't have the relevant rights to allow me to put it up for integration so if it's not up for integration by the time you get in that would be appreciated! This should cherry-pick cleanly to both: MOODLE_21_STABLE; and MOODLE_22_STABLE.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Andrew, this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now.
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          Hi,
          This is working great!
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - Hi, This is working great! Thanks
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          This is now available in the git and cvs repositories.

          Consider the responsibility of your fingerprints engraved there for future generations!

          Thanks for the work, closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12