Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.4
    • Component/s: Messages
    • Labels:

      Description

      message_get_my_providers() has been deprecated since 2.1 and can be removed any time after 2.2

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

            Show
            Dan Poltawski added a comment - Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.
            Hide
            Ankit Agarwal added a comment -

            Hi Rajesh,
            This looks good.
            +1 for integration.
            Thanks

            Show
            Ankit Agarwal added a comment - Hi Rajesh, This looks good. +1 for integration. Thanks
            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Rajesh Taneja added a comment -

            Branch re-based.

            Show
            Rajesh Taneja added a comment - Branch re-based.
            Hide
            Dan Poltawski added a comment -

            Hi Guys,

            This hasn't been throwing a debugging notice for a release so it would be unkind to just drop it like this.

            How are third party developers supposed to know we've deprecated it? We can't expect them to just review every piece of code

            So, instead lets:
            1/ Make this function throw a DEBUG_DEVELOPER debugging message for 2.4
            2/ Create a new issue to drop it in 2.5.

            Show
            Dan Poltawski added a comment - Hi Guys, This hasn't been throwing a debugging notice for a release so it would be unkind to just drop it like this. How are third party developers supposed to know we've deprecated it? We can't expect them to just review every piece of code So, instead lets: 1/ Make this function throw a DEBUG_DEVELOPER debugging message for 2.4 2/ Create a new issue to drop it in 2.5.
            Hide
            Rajesh Taneja added a comment - - edited

            I agree with you Dan, but similar functions were removed in other bugs like MDL-31942, MDL-31134
            Let me know if you want me to add debug message.

            Show
            Rajesh Taneja added a comment - - edited I agree with you Dan, but similar functions were removed in other bugs like MDL-31942 , MDL-31134 Let me know if you want me to add debug message.
            Hide
            Dan Poltawski added a comment -

            Yes I do, thats why I said it

            Note that I didn't agree with removing those other issues without notice. But this issue is also slightly different because its a general Moodle library function.

            But, i'd like us to throw debugging messages for release on any to be removed function by policy.

            Show
            Dan Poltawski added a comment - Yes I do, thats why I said it Note that I didn't agree with removing those other issues without notice. But this issue is also slightly different because its a general Moodle library function. But, i'd like us to throw debugging messages for release on any to be removed function by policy.
            Hide
            Rajesh Taneja added a comment -

            Updated code to add debug message and update deprecated doc to 2.5

            Show
            Rajesh Taneja added a comment - Updated code to add debug message and update deprecated doc to 2.5
            Hide
            Dan Poltawski added a comment -

            Thanks Raj, have integrated that now.

            Show
            Dan Poltawski added a comment - Thanks Raj, have integrated that now.
            Hide
            Frédéric Massart added a comment -

            Test successful on master. Thanks!

            Show
            Frédéric Massart added a comment - Test successful on master. Thanks!
            Hide
            Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: