The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

Hi Rajesh,
This looks good.
+1 for integration.
Thanks

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Branch re-based.

Hi Guys,

This hasn't been throwing a debugging notice for a release so it would be unkind to just drop it like this.

How are third party developers supposed to know we've deprecated it? We can't expect them to just review every piece of code

So, instead lets:
1/ Make this function throw a DEBUG_DEVELOPER debugging message for 2.4
2/ Create a new issue to drop it in 2.5.

I agree with you Dan, but similar functions were removed in other bugs like MDL-31942, MDL-31134
Let me know if you want me to add debug message.

Yes I do, thats why I said it

Note that I didn't agree with removing those other issues without notice. But this issue is also slightly different because its a general Moodle library function.

But, i'd like us to throw debugging messages for release on any to be removed function by policy.

Updated code to add debug message and update deprecated doc to 2.5

Thanks Raj, have integrated that now.

Test successful on master. Thanks!

yay, it works!

This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

Thank you all for taking the time to get us here.

cheers!