Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31147 META: Collect together deprecated code changes for Moodle 2.3
  3. MDL-31033

Clear out /message/send_form.php

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.2
          • Fix Version/s: 2.4
          • Component/s: Messages
          • Labels:
          • Database:
            Any
          • Testing Instructions:
            Hide

            Go to messaging (My profile > Messages) and send another user a personal message.

            Log in as that user, go to My Profile > Messages and check that the message appears for them. It doesnt matter whether its read or not, just that the message appears at all.

            Show
            Go to messaging (My profile > Messages) and send another user a personal message. Log in as that user, go to My Profile > Messages and check that the message appears for them. It doesnt matter whether its read or not, just that the message appears at all.
          • Affected Branches:
            MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-31033_message_deprecated
          • Pull Master Diff URL:

            Description

            It contains a bunch of commented out code that can probably just be deleted. Find out why its there and whether it can just be removed.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  andyjdavis Andrew Davis added a comment -

                  Adding a branch and testing instructions. Putting this up for peer review.

                  Show
                  andyjdavis Andrew Davis added a comment - Adding a branch and testing instructions. Putting this up for peer review.
                  Hide
                  Permalink
                  ankit_frenz Ankit Agarwal added a comment -

                  Hi Andrew,
                  Do we need to overwrite the set_data and get_data methods when they are simply calling parent methods?
                  will it make more sense to remove them completely?

                  thanks

                  Show
                  ankit_frenz Ankit Agarwal added a comment - Hi Andrew, Do we need to overwrite the set_data and get_data methods when they are simply calling parent methods? will it make more sense to remove them completely? thanks
                  Hide
                  Permalink
                  andyjdavis Andrew Davis added a comment -

                  Those overrides are rather pointless arent they. Ive removed them. Submitting for integration.

                  Show
                  andyjdavis Andrew Davis added a comment - Those overrides are rather pointless arent they. Ive removed them. Submitting for integration.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Hi Andrew,

                  Just double checking, but the only thing happening here is that code is being cleaned up.
                  If so then I may stop the review on this and leave it until after the minor releases at the end of this week.
                  As master and 23 have to stay in sync it keeps things simpler if left until after then.

                  Cheers
                  Sam

                  Show
                  samhemelryk Sam Hemelryk added a comment - Hi Andrew, Just double checking, but the only thing happening here is that code is being cleaned up. If so then I may stop the review on this and leave it until after the minor releases at the end of this week. As master and 23 have to stay in sync it keeps things simpler if left until after then. Cheers Sam
                  Hide
                  Permalink
                  andyjdavis Andrew Davis added a comment -

                  Yep, its just clean up. No rush.

                  Show
                  andyjdavis Andrew Davis added a comment - Yep, its just clean up. No rush.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Cool thanks Andrew, I'll stop the review on this now and shift it back to next week (when it can go in for sure!)

                  Show
                  samhemelryk Sam Hemelryk added a comment - Cool thanks Andrew, I'll stop the review on this now and shift it back to next week (when it can go in for sure!)
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Andrew, this has been integrated now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now.
                  Hide
                  Permalink
                  fred Frédéric Massart added a comment -

                  Passed. Thanks guys!

                  Show
                  fred Frédéric Massart added a comment - Passed. Thanks guys!
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Congratulations!

                  You've made it into the weekly release!

                  Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
                  http://www.youtube.com/watch?v=_QhpHUmVCmY

                  Show
                  poltawski Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      1 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        3/Dec/12