Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31036

Quick grading accepts plain text but truncates special characters

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      Test One:

      1. Create an assignment that has users.
        1. Under Feedback select 'Feedback comments' and 'Offline grading worksheet'.
      2. Go to the assignment and view/grade submissions.
        1. At the bottom where there is Options, select 'Quick grading'.
      3. Insert the comment "Your formula should be IF(C7<30000,E7*15%,E7*28%)".
      4. Save the feedback.

      Expected: Above text should now be visible without any alteration in the feedback textbox.

      Note: If you slow-grade, or use Atto any special characters include those that make up html tags will also be shown in full in the textbox. This is expected.

      i.e. a blue hyper link added as "my link" into feedback when slow-grading will appear as <p><a href="someurl">my link</a></p> in the feedback textbox when quickgrading.

      Show
      Test One: Create an assignment that has users. Under Feedback select 'Feedback comments' and 'Offline grading worksheet'. Go to the assignment and view/grade submissions. At the bottom where there is Options, select 'Quick grading'. Insert the comment "Your formula should be IF(C7<30000,E7*15%,E7*28%)". Save the feedback. Expected: Above text should now be visible without any alteration in the feedback textbox. Note: If you slow-grade, or use Atto any special characters include those that make up html tags will also be shown in full in the textbox. This is expected. i.e. a blue hyper link added as "my link" into feedback when slow-grading will appear as <p><a href="someurl">my link</a></p> in the feedback textbox when quickgrading.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31036-master
    • Sprint:
      FRONTEND Sprint 16, Team B Sprint 1, Team Beards Sprint 2
    • Issue size:
      Small

      Description

      This is split off from MDL-17814. When grading, if a faculty member turns on quick grading after leaving rich text feedback they will encounter the markup in the simple textarea (see attached screenshot). This is non-intuitive and can cause undesired data loss if the faculty member tries erasing the markup. I think one solution would be to disable quick-grading if rich text editing is enable AND there's already feedback and, conversely, to disable the rich text editor if quick grading is enabled.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                24 Vote for this issue
                Watchers:
                22 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Mar/15