Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31040

mouseover text on group toggle button inconsistant and breaks RTL support

    XMLWordPrintable

Details

    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MDL-31040-master-2
    • Hide

      Replication Instructions

      • Disable AJAX in your profile
      • Navigate to a course
      • Turn editing on
      • Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome)
        • You'll find that the text for the anchor and image's alt and title text differs
      • Note that the icon and parent anchor have a mixture of titles
      • Edit the Course Settings to set "Force Group Mode" to "Yes", and 'Group Mode' to something other than 'No Groups'
      • Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome)
        • You'll find that the text for the anchor and image's alt and title text differs
      • Edit the Course Settings to set the Course Format to 'Social'
      • Add the 'Social Activities' block
      • Inspect a Group Mode toggle icon for an activity in the block
        • You'll find that the text for the anchor and image's alt and title text differs
      • Turn AJAX back on in your profile
      • Refresh the page
      • Rinse, Wash Repeat

      Testing the fix

      The above instructions still apply, but the alt and title text should no longer differ

      Show
      Replication Instructions Disable AJAX in your profile Navigate to a course Turn editing on Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome) You'll find that the text for the anchor and image's alt and title text differs Note that the icon and parent anchor have a mixture of titles Edit the Course Settings to set "Force Group Mode" to "Yes", and 'Group Mode' to something other than 'No Groups' Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome) You'll find that the text for the anchor and image's alt and title text differs Edit the Course Settings to set the Course Format to 'Social' Add the 'Social Activities' block Inspect a Group Mode toggle icon for an activity in the block You'll find that the text for the anchor and image's alt and title text differs Turn AJAX back on in your profile Refresh the page Rinse, Wash Repeat Testing the fix The above instructions still apply, but the alt and title text should no longer differ

    Description

      When in editing mode, the alt and title text for the image and anchor for the groupmode toggle is inconsistant
      The anchor title is "<mode> (Click to change)" whilst the title and alt for the image is simply "<mode>"

      with ajax enabled, all are set to the "<mode> (Click to change)" version, but the way in which this is implemented breaks RTL support as it uses something akin to:

      <mode> . ' (' . get_string('clicktochange') . ')'

      in both the JS and PHP

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Andrew Davis Andrew Davis
              Sam Hemelryk Sam Hemelryk
              Rossiani Wijaya Rossiani Wijaya
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Aya Saad, David Mudrák (@mudrd8mz), Helen Foster, Victor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Mar/12