Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31040

mouseover text on group toggle button inconsistant and breaks RTL support

    Details

    • Testing Instructions:
      Hide

      Replication Instructions

      • Disable AJAX in your profile
      • Navigate to a course
      • Turn editing on
      • Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome)
        • You'll find that the text for the anchor and image's alt and title text differs
      • Note that the icon and parent anchor have a mixture of titles
      • Edit the Course Settings to set "Force Group Mode" to "Yes", and 'Group Mode' to something other than 'No Groups'
      • Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome)
        • You'll find that the text for the anchor and image's alt and title text differs
      • Edit the Course Settings to set the Course Format to 'Social'
      • Add the 'Social Activities' block
      • Inspect a Group Mode toggle icon for an activity in the block
        • You'll find that the text for the anchor and image's alt and title text differs
      • Turn AJAX back on in your profile
      • Refresh the page
      • Rinse, Wash Repeat

      Testing the fix

      The above instructions still apply, but the alt and title text should no longer differ

      Show
      Replication Instructions Disable AJAX in your profile Navigate to a course Turn editing on Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome) You'll find that the text for the anchor and image's alt and title text differs Note that the icon and parent anchor have a mixture of titles Edit the Course Settings to set "Force Group Mode" to "Yes", and 'Group Mode' to something other than 'No Groups' Inspect a Group Mode toggle icon for an activity in your browser (I'm using Chrome) You'll find that the text for the anchor and image's alt and title text differs Edit the Course Settings to set the Course Format to 'Social' Add the 'Social Activities' block Inspect a Group Mode toggle icon for an activity in the block You'll find that the text for the anchor and image's alt and title text differs Turn AJAX back on in your profile Refresh the page Rinse, Wash Repeat Testing the fix The above instructions still apply, but the alt and title text should no longer differ
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31040-master-2

      Description

      When in editing mode, the alt and title text for the image and anchor for the groupmode toggle is inconsistant
      The anchor title is "<mode> (Click to change)" whilst the title and alt for the image is simply "<mode>"

      with ajax enabled, all are set to the "<mode> (Click to change)" version, but the way in which this is implemented breaks RTL support as it uses something akin to:

      <mode> . ' (' . get_string('clicktochange') . ')'

      in both the JS and PHP

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Mar/12