I've been working on a patch for this and will submit in the morning when I've finished testing it

Thanks for working on this.

I've created a patch which addresses both of these issues and another related issue.
Please note that it's not possible to use the M.util.get_string() functions here because they're loaded too late for the existing code in section_classes.js so I've resorted to changing the existing strings to suit.

I've started work on migrating the existing YUI2 code in lib/ajax/section_classes.js to a YUI3 module in course/yui which will resolve this issue properly for 2.3 onwards.

Generally, don't put replication instructions in the test instructions field. If however the testing instructions are effectively just the replication instructions but with a slightly different result you can refer the tester to the replication instructions with an explanation of what should be different.

The code is no longer using 'forcedmode'. Instead it uses the new string 'forcedmodeinbrackets'. I can't see anywhere else that uses the string 'forcedmode'. If its not being used remove it from the lang file. Same for 'clicktochange'. If they're genuinely not being used its always nice to get rid of strings to save people wasting time translating them into other languages.

I've updated the commit to remove the 'forcedmode' and 'clicktochange' strings – I'd not removed them before as I wasn't sure what the deal was with removing language strings.

I've also rebased on the latest weeklies.

In addition to master, this should cherry-pick cleanly onto MOODLE_22_STABLE.
I've provided a separate MOODLE_21_STABLE branch as this doesn't cherry-pick cleanly onto 21

Adding David here..

David - Andrew asked me to submit for integration for I just wanted to pick your expertise before doing this. Is this sort of change better in master only because of the ability to break non-english language strings - is it better we introduce a new string?? The problem I see with doing it in the stable branch that we break <2.2.3 for example

Summarizing the discussion that just happened in the chat:

1. remove the strings from master only
2. do not remove them on stable branches
3. let me know that I shall put the strings on a greylist in AMOS for 2.1 and 2.2

Updated branches as discussed with Dan and David in the developer chat.

The 21 branch only adds strings but the code is different to 22 and master
The 22 branch only adds strings but has the same code as master
The master branch removes the old string, and adds new strings

Thanks Andrew, this has been integrated now

This is working fine.

Test passed.

This is now available in the git and cvs repositories.

Consider the responsibility of your fingerprints engraved there for future generations!

Thanks for the work, closing, ciao