Moodle

Restore - PHP Notices during restore of 1.9 zip file

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1, 2.2, 2.3
  • Fix Version/s: 2.1.5, 2.2.2
  • Component/s: Backup, Questions
  • Labels:
  • Testing Instructions:
    Hide

    1. Restore the test backup file attached to MDL-16513.
    2. Verify that there are no notices relating to questions. (Note, I did get a notice about something else when I tested.)
    3. Once the restore is done, go into the question bank and edit and/or preview the matching question, and verify that it is all present and correct.

    Show
    1. Restore the test backup file attached to MDL-16513 . 2. Verify that there are no notices relating to questions. (Note, I did get a notice about something else when I tested.) 3. Once the restore is done, go into the question bank and edit and/or preview the matching question, and verify that it is all present and correct.
  • Workaround:
    Hide

    Turn debugging off and the notices will not be seen.

    Show
    Turn debugging off and the notices will not be seen.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

While doing a restore - creating a new course - the following PHP notices appear:

Notice: Undefined index: matchoptions in /home/arborrow/NetBeansProjects/m22/question/type/match/backup/moodle1/lib.php on line 59

Notice: Undefined index: original_site_identifier_hash in /home/arborrow/NetBeansProjects/m22/backup/util/helper/backup_general_helper.class.php on line 141

This is a pretty trivial matter but it came up while looking at closing MDL-16513 so I figured I would create an issue should someone want something that is hopefully easy to work on.

Peace - Anthony

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-16513 Restore: PHP Notice: Undefined index: RATINGS in /home/arborrow/Moodle/code/19stable/mod/data/restorelib.php on line 380

  • Trivial - Cosmetic problem like misspelt words or misaligned text
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
is blocked by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31124 MDL-30610 changes breaks restore of 1.9 backups

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31317 Notice when restoring a 1.9 backup

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

This looks very similar to MDL-30742 (fix http://fisheye.moodle.org/changelog/Moodle/?cs=b5f65ba14cfa8d940563face1ef61b271dd8a0e6) - only for a different qtype.

Show
Tim Hunt added a comment - This looks very similar to MDL-30742 (fix http://fisheye.moodle.org/changelog/Moodle/?cs=b5f65ba14cfa8d940563face1ef61b271dd8a0e6 ) - only for a different qtype.
Hide
Permalink
Tim Hunt added a comment -

I think this is something like what we need, but I can't test it at the moment because of MDL-31124.

Show
Tim Hunt added a comment - I think this is something like what we need, but I can't test it at the moment because of MDL-31124 .
Hide
Permalink
Tim Hunt added a comment -

Now that the blocking bug is fixed, I can test this and verify that my propose fix seems to work, so, submitting for integration.

Show
Tim Hunt added a comment - Now that the blocking bug is fixed, I can test this and verify that my propose fix seems to work, so, submitting for integration.
Hide
Permalink
Tim Hunt added a comment -

Just reading the description again. To clarify, I have fixed the matchoptions thing. I will file a new bug about the Notice: Undefined index: original_site_identifier_hash problem, which I also noticed when doing a test restore.

Show
Tim Hunt added a comment - Just reading the description again. To clarify, I have fixed the matchoptions thing. I will file a new bug about the Notice: Undefined index: original_site_identifier_hash problem, which I also noticed when doing a test restore.
Hide
Permalink
Tim Hunt added a comment -

MDL-31317

Show
Tim Hunt added a comment - MDL-31317
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
Hide
Permalink
Jason Fowler added a comment -

Worked as expected, no notices related to quiz/question

Show
Jason Fowler added a comment - Worked as expected, no notices related to quiz/question
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

Nah, joking, many thanks! Closing this a fixed, ciao

Show
Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: