Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31058

Restore - PHP Notices during restore of 1.9 zip file

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Backup, Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Restore the test backup file attached to MDL-16513.
      2. Verify that there are no notices relating to questions. (Note, I did get a notice about something else when I tested.)
      3. Once the restore is done, go into the question bank and edit and/or preview the matching question, and verify that it is all present and correct.

      Show
      1. Restore the test backup file attached to MDL-16513 . 2. Verify that there are no notices relating to questions. (Note, I did get a notice about something else when I tested.) 3. Once the restore is done, go into the question bank and edit and/or preview the matching question, and verify that it is all present and correct.
    • Workaround:
      Hide

      Turn debugging off and the notices will not be seen.

      Show
      Turn debugging off and the notices will not be seen.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      While doing a restore - creating a new course - the following PHP notices appear:

      Notice: Undefined index: matchoptions in /home/arborrow/NetBeansProjects/m22/question/type/match/backup/moodle1/lib.php on line 59

      Notice: Undefined index: original_site_identifier_hash in /home/arborrow/NetBeansProjects/m22/backup/util/helper/backup_general_helper.class.php on line 141

      This is a pretty trivial matter but it came up while looking at closing MDL-16513 so I figured I would create an issue should someone want something that is hopefully easy to work on.

      Peace - Anthony

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            This looks very similar to MDL-30742 (fix http://fisheye.moodle.org/changelog/Moodle/?cs=b5f65ba14cfa8d940563face1ef61b271dd8a0e6) - only for a different qtype.

            Show
            timhunt Tim Hunt added a comment - This looks very similar to MDL-30742 (fix http://fisheye.moodle.org/changelog/Moodle/?cs=b5f65ba14cfa8d940563face1ef61b271dd8a0e6 ) - only for a different qtype.
            Hide
            timhunt Tim Hunt added a comment -

            I think this is something like what we need, but I can't test it at the moment because of MDL-31124.

            Show
            timhunt Tim Hunt added a comment - I think this is something like what we need, but I can't test it at the moment because of MDL-31124 .
            Hide
            timhunt Tim Hunt added a comment -

            Now that the blocking bug is fixed, I can test this and verify that my propose fix seems to work, so, submitting for integration.

            Show
            timhunt Tim Hunt added a comment - Now that the blocking bug is fixed, I can test this and verify that my propose fix seems to work, so, submitting for integration.
            Hide
            timhunt Tim Hunt added a comment -

            Just reading the description again. To clarify, I have fixed the matchoptions thing. I will file a new bug about the Notice: Undefined index: original_site_identifier_hash problem, which I also noticed when doing a test restore.

            Show
            timhunt Tim Hunt added a comment - Just reading the description again. To clarify, I have fixed the matchoptions thing. I will file a new bug about the Notice: Undefined index: original_site_identifier_hash problem, which I also noticed when doing a test restore.
            Hide
            timhunt Tim Hunt added a comment -
            Show
            timhunt Tim Hunt added a comment - MDL-31317
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            phalacee Jason Fowler added a comment -

            Worked as expected, no notices related to quiz/question

            Show
            phalacee Jason Fowler added a comment - Worked as expected, no notices related to quiz/question
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

            Nah, joking, many thanks! Closing this a fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12