Details

    • Rank:
      37505

      Description

      The method forum_get_subscribed_forums() found in mod/forum/lib.php doesn't make use of the passed course, so it gets information on all forums on the site instead of just ones for the course. This has proven to be a very large performance hit on sites with a lot of forums.

      1. Moodle1.patch
        0.7 kB
        Mark Nielsen
      2. Moodle2.patch
        0.8 kB
        Mark Nielsen

        Issue Links

          Activity

          Mark Nielsen created issue -
          Hide
          Mark Nielsen added a comment -

          Attaching patches for Moodle 1.9 (Moodle1.patch) and Moodle 2.1 (Moodle2.patch)

          Show
          Mark Nielsen added a comment - Attaching patches for Moodle 1.9 (Moodle1.patch) and Moodle 2.1 (Moodle2.patch)
          Mark Nielsen made changes -
          Field Original Value New Value
          Attachment Moodle1.patch [ 26324 ]
          Attachment Moodle2.patch [ 26325 ]
          Mark Nielsen made changes -
          Labels moodlerooms partner patch
          Mark Nielsen made changes -
          Priority Minor [ 4 ] Critical [ 2 ]
          Difficulty Easy [ 10023 ]
          Hide
          Mark Nielsen added a comment -

          Also note that forum_get_subscribed_forums() is only used on index.php, so regression testing should be minimal.

          Show
          Mark Nielsen added a comment - Also note that forum_get_subscribed_forums() is only used on index.php, so regression testing should be minimal.
          Hide
          Michael de Raadt added a comment -

          Thanks for spotting that and supplying a solution.

          Show
          Michael de Raadt added a comment - Thanks for spotting that and supplying a solution.
          Michael de Raadt made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Labels moodlerooms partner patch moodlerooms partner patch triaged
          Petr Škoda made changes -
          Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Hide
          Petr Škoda added a comment -

          to integrators: please cherry pick to supported 2.x branches too

          Thanks for the report and patch!

          Show
          Petr Škoda added a comment - to integrators: please cherry pick to supported 2.x branches too Thanks for the report and patch!
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w04_MDL-31081_m23_forumindex
          Pull Master Branch w04_MDL-31081_m23_forumindex
          Pull from Repository git://github.com/skodak/moodle.git
          Fix Version/s 1.9.17 [ 11555 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Pull 1.9 Diff URL https://github.com/skodak/moodle/compare/MOODLE_19_STABLE...w04_MDL-31081_m19_forumindex
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (21, 22 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master), thanks!
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.2 [ 10656 ]
          Affects Version/s 2.1 [ 10370 ]
          Affects Version/s 2.0.4 [ 10652 ]
          Affects Version/s 2.1.4 [ 11452 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s 1.9.17 [ 11555 ]
          Jason Fowler made changes -
          Tester phalacee
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester phalacee stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing this. I've tested it as admin/teacher/pupil against forced, prevented and normal subscription forums. All buttons and statuses seem to have sense.

          PS: I've noticed 2 minor (unrelated) problems while testing, will be searching/creating them later.

          Show
          Eloy Lafuente (stronk7) added a comment - Passing this. I've tested it as admin/teacher/pupil against forced, prevented and normal subscription forums. All buttons and statuses seem to have sense. PS: I've noticed 2 minor (unrelated) problems while testing, will be searching/creating them later.
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

          Nah, joking, many thanks! Closing this a fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 27/Jan/12
          Eloy Lafuente (stronk7) made changes -
          Link This issue testing discovered MDL-31426 [ MDL-31426 ]
          Eloy Lafuente (stronk7) made changes -
          Link This issue testing discovered MDL-31428 [ MDL-31428 ]

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: