Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31089

New posts listing on 'My Moodle' ignores groups.

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      Requirments

      1. It is quite difficult to write testing instructions for all possible edge cases effected by this patch. Given test instructions might not be 100% accurate, also will require a basic understanding of the changes made by the patch and expected results.
      2. A course with two groups (1,2) with atleast 2 student in each (student 1,2 - group 1 and student 3-4 in group 2)
      3. Create a discussion by each student in a forum, and make a reply by the same user to it. Sequentially by 1 ,2 ,3,4
      4. Dont visit the forum in middle of the test (or the course for that matter).
      5. Test the following:-

      TEST 1
      Course group mode : visible
      course groupmode force : true
      forum groupmode: doesnt matter
      Student 1 should see all posts in my home page
      Student 2 should see all posts in my home page
      Student 3 should see all posts in my home page
      Student 4 should see all posts in my home page
      Make sure post count is right
      Go to the course page and make sure recent activity block only display posts in his/her group

      TEST 2
      Course group mode : SEPARATE
      course groupmode force : true
      forum groupmode: doesnt matter
      Student 1 should see only student 2's posts in my home page
      Student 2 should see only no posts in my home page
      Student 3 should see only student 4's posts in my home page
      Student 4 should see only no posts in my home page
      Make sure post count is right
      Go to the course page and make sure recent activity block only display posts in his/her group

      TEST 3
      Course group mode : doesn't matter
      course groupmode force : false
      forum groupmode: SEPARATE
      Student 1 should see only student 2's posts in my home page
      Student 2 should see only no posts in my home page
      Student 3 should see only student 4's posts in my home page
      Student 4 should see only no posts in my home page
      Make sure post count is right
      Go to the course page and make sure recent activity block only display posts in his/her group

      TEST 4
      Course group mode : doesn't matter
      course groupmode force : false
      forum groupmode: visisble
      Student 1 should see all posts in my home page
      Student 2 should see all posts in my home page
      Student 3 should see all posts in my home page
      Student 4 should see all posts in my home page
      Make sure post count is right
      Go to the course page and make sure recent activity block only display posts in his/her group

      TEST 5
      Course group mode : doesn't matter
      course groupmode force : false
      forum groupmode: no groups
      Student 1 should see all posts in my home page
      Student 2 should see all posts in my home page
      Student 3 should see all posts in my home page
      Student 4 should see all posts in my home page
      Make sure post count is right
      Go to the course page and make sure recent activity block only display posts in his/her group

      TEST 6
      Course group mode : NOGROUPS
      course groupmode force : true
      forum groupmode: doesn't matter
      Student 1 should see all posts in my home page
      Student 2 should see all posts in my home page
      Student 3 should see all posts in my home page
      Student 4 should see all posts in my home page
      Make sure post count is right
      Go to the course page and make sure recent activity block only display posts in his/her group

      1. Note:- All posts means all posts made after the user last visited the course, expect the user's own posts which are never shown
      Show
      Requirments It is quite difficult to write testing instructions for all possible edge cases effected by this patch. Given test instructions might not be 100% accurate, also will require a basic understanding of the changes made by the patch and expected results. A course with two groups (1,2) with atleast 2 student in each (student 1,2 - group 1 and student 3-4 in group 2) Create a discussion by each student in a forum, and make a reply by the same user to it. Sequentially by 1 ,2 ,3,4 Dont visit the forum in middle of the test (or the course for that matter). Test the following:- TEST 1 Course group mode : visible course groupmode force : true forum groupmode: doesnt matter Student 1 should see all posts in my home page Student 2 should see all posts in my home page Student 3 should see all posts in my home page Student 4 should see all posts in my home page Make sure post count is right Go to the course page and make sure recent activity block only display posts in his/her group TEST 2 Course group mode : SEPARATE course groupmode force : true forum groupmode: doesnt matter Student 1 should see only student 2's posts in my home page Student 2 should see only no posts in my home page Student 3 should see only student 4's posts in my home page Student 4 should see only no posts in my home page Make sure post count is right Go to the course page and make sure recent activity block only display posts in his/her group TEST 3 Course group mode : doesn't matter course groupmode force : false forum groupmode: SEPARATE Student 1 should see only student 2's posts in my home page Student 2 should see only no posts in my home page Student 3 should see only student 4's posts in my home page Student 4 should see only no posts in my home page Make sure post count is right Go to the course page and make sure recent activity block only display posts in his/her group TEST 4 Course group mode : doesn't matter course groupmode force : false forum groupmode: visisble Student 1 should see all posts in my home page Student 2 should see all posts in my home page Student 3 should see all posts in my home page Student 4 should see all posts in my home page Make sure post count is right Go to the course page and make sure recent activity block only display posts in his/her group TEST 5 Course group mode : doesn't matter course groupmode force : false forum groupmode: no groups Student 1 should see all posts in my home page Student 2 should see all posts in my home page Student 3 should see all posts in my home page Student 4 should see all posts in my home page Make sure post count is right Go to the course page and make sure recent activity block only display posts in his/her group TEST 6 Course group mode : NOGROUPS course groupmode force : true forum groupmode: doesn't matter Student 1 should see all posts in my home page Student 2 should see all posts in my home page Student 3 should see all posts in my home page Student 4 should see all posts in my home page Make sure post count is right Go to the course page and make sure recent activity block only display posts in his/her group Note:- All posts means all posts made after the user last visited the course, expect the user's own posts which are never shown
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31089_master
    • Story Points:
      40
    • Sprint:
      BACKEND Sprint 14

      Description

      Students are seeing 'x posts since last login' notifications under 'course overview' in My Moodle even if the posts belong to groups that they do not have access to.

      Presumably, students should only get that notification if there are new posts that they are able to see.

      Replication steps:

      1. Create a course with a forum that is set to 'separate groups'.
      2. Create two groups and enrol students into both.
      3. Post something on one group's forum.
      4. Log in as a student in the other group and see '1 post since last login' message under the subject in 'course overview'.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dmonllao David Monllaó
              Reporter:
              aestivus Louise Bennett
              Peer reviewer:
              Marina Glancy
              Integrator:
              Sam Hemelryk
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              11 Vote for this issue
              Watchers:
              19 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Sep/14