Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide
      1. Open a terminal
      2. Navigate to your moodle directory
      3. Run this command (or use whatever search tool you prefer) on master, 2.2 and 2.1 to find any remaining instances of the string "bellow"
        grep -r bellow
        
      4. If you do find an instances run the following and locate the lines (which should have a date next to it)
        git blame <filename>
        
      5. If you found no such instance of "bellow" or if the lines were created after this patch was submitted this test passes.
      Show
      Open a terminal Navigate to your moodle directory Run this command (or use whatever search tool you prefer) on master, 2.2 and 2.1 to find any remaining instances of the string "bellow" grep -r bellow If you do find an instances run the following and locate the lines (which should have a date next to it) git blame <filename> If you found no such instance of "bellow" or if the lines were created after this patch was submitted this test passes.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-31107_fixing_below_typos
    • Rank:
      37535

      Description

      As reported by Erkki Laaneoks via email:

      [err_networkingoff_help,portfolio_mahara] includes typo in word "pugin". IMHO it should be "plugin".
      [printintroexplain,mod_resource] includes typo in word "bellow". IMHO it should be "below".
      [tiierror1024,plagiarism_turnitin] includes typo in word "legitamate". IMHO it should be "legitimate".

      Please search for "bellow" everywhere in Moodle - it seems to be a common typo. Thanks.

        Activity

        Hide
        Gerard Caulfield added a comment -

        Hi David

        1. I've fixed err_networkingoff_help,portfolio_mahara in MDL-30723
        2. I've fixed printintroexplain,mod_resource in MDL-29153
        3. I can not locate tiierror1024,plagiarism_turnitin
        4. You were correct about the many other instances of bellow and as such I've supplied a patch for them.

        Thanks

        Show
        Gerard Caulfield added a comment - Hi David I've fixed err_networkingoff_help,portfolio_mahara in MDL-30723 I've fixed printintroexplain,mod_resource in MDL-29153 I can not locate tiierror1024,plagiarism_turnitin You were correct about the many other instances of bellow and as such I've supplied a patch for them. Thanks
        Hide
        David Mudrak added a comment -

        Thanks Gerard. ANy reason why this patch for 2.1 is missing here?

        Show
        David Mudrak added a comment - Thanks Gerard. ANy reason why this patch for 2.1 is missing here?
        Hide
        Gerard Caulfield added a comment -

        I was following "Affects Version/s: 2.2.1"

        Show
        Gerard Caulfield added a comment - I was following "Affects Version/s: 2.2.1"
        Hide
        Ankit Agarwal added a comment - - edited

        Hi Gerard,
        That is really nice fix. Some suggestions:-

        • You already fixed the typo in mod_resource in MDL-29153, there is no point repeating the same fix here.
        • lib/db/upgrade in 22 still contains an instance of "bellow"
        • +1 to add a branch for 21 as well. In general don't consider "Affects version" conclusive.
        • Don't forget to update testing instruction. If no testing is required just mention to grep and see the changes

        Thanks

        Show
        Ankit Agarwal added a comment - - edited Hi Gerard, That is really nice fix. Some suggestions:- You already fixed the typo in mod_resource in MDL-29153 , there is no point repeating the same fix here. lib/db/upgrade in 22 still contains an instance of "bellow" +1 to add a branch for 21 as well. In general don't consider "Affects version" conclusive. Don't forget to update testing instruction. If no testing is required just mention to grep and see the changes Thanks
        Hide
        Gerard Caulfield added a comment -

        Thanks Ankit, all fixed and I'll make sure to add the test.

        Show
        Gerard Caulfield added a comment - Thanks Ankit, all fixed and I'll make sure to add the test.
        Hide
        Sam Hemelryk added a comment -

        Thanks Gerry - this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Gerry - this has been integrated now
        Hide
        Michael de Raadt added a comment -

        Test result: Success

        Instances of terms "plugin", "legitimate" and "below" have been corrected in all supported branches.

        It looks like "plugin" and "legitimate" were corrected as part of MDL-30723.

        Show
        Michael de Raadt added a comment - Test result: Success Instances of terms "plugin", "legitimate" and "below" have been corrected in all supported branches. It looks like "plugin" and "legitimate" were corrected as part of MDL-30723 .
        Hide
        Eloy Lafuente (stronk7) added a comment -

        It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

        Closing as fixed, heading to zzzZZZzzz, niao

        Show
        Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: